Skip to content

Fixing namespace for image samples #3208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 5, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
using System;
using System.IO;
using Microsoft.ML;
using Microsoft.ML.Data;

namespace Microsoft.ML.Samples.Dynamic
namespace Samples.Dynamic
{
public static class ConvertToGrayscale
{
@@ -16,7 +17,7 @@ public static void Example()
// Downloading a few images, and an images.tsv file, which contains a list of the files from the dotnet/machinelearning/test/data/images/.
// If you inspect the fileSystem, after running this line, an "images" folder will be created, containing 4 images, and a .tsv file
// enumerating the images.
var imagesDataFile = SamplesUtils.DatasetUtils.DownloadImages();
var imagesDataFile = Microsoft.ML.SamplesUtils.DatasetUtils.DownloadImages();

// Preview of the content of the images.tsv file
//
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
using System;
using System.Collections.Generic;
using System.Linq;
using Microsoft.ML;
using Microsoft.ML.Data;

namespace Microsoft.ML.Samples.Dynamic
namespace Samples.Dynamic
{
public static class ConvertToImage
{
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
using System.IO;
using System.Linq;
using Microsoft.ML;
using Microsoft.ML.Data;

namespace Microsoft.ML.Samples.Dynamic
namespace Samples.Dynamic
{
public static class DnnFeaturizeImage
{
@@ -15,7 +16,7 @@ public static void Example()
// Downloading a few images, and an images.tsv file, which contains a list of the files from the dotnet/machinelearning/test/data/images/.
// If you inspect the fileSystem, after running this line, an "images" folder will be created, containing 4 images, and a .tsv file
// enumerating the images.
var imagesDataFile = SamplesUtils.DatasetUtils.DownloadImages();
var imagesDataFile = Microsoft.ML.SamplesUtils.DatasetUtils.DownloadImages();
Copy link
Contributor

@rogancarr rogancarr Apr 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Microsoft.ML. [](start = 33, length = 13)

Do you need this? You don't in ConvertToGrayScale.

Ditto for the rest of the files with this pattern. #Resolved

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added to ConvertToGrayScale in iteration 2 (else its compile time error)


In reply to: 272409998 [](ancestors = 272409998)


// Preview of the content of the images.tsv file, which lists the images to operate on
//
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
using System;
using System.IO;
using System.Linq;
using Microsoft.ML;
using Microsoft.ML.Data;

namespace Microsoft.ML.Samples.Dynamic
namespace Samples.Dynamic
{
public static class ExtractPixels
{
@@ -18,7 +19,7 @@ public static void Example()
// Downloading a few images, and an images.tsv file, which contains a list of the files from the dotnet/machinelearning/test/data/images/.
// If you inspect the fileSystem, after running this line, an "images" folder will be created, containing 4 images, and a .tsv file
// enumerating the images.
var imagesDataFile = SamplesUtils.DatasetUtils.DownloadImages();
var imagesDataFile = Microsoft.ML.SamplesUtils.DatasetUtils.DownloadImages();

// Preview of the content of the images.tsv file
//
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
using System;
using System.IO;
using Microsoft.ML;
using Microsoft.ML.Data;

namespace Microsoft.ML.Samples.Dynamic
namespace Samples.Dynamic
{
public static class LoadImages
{
@@ -16,7 +17,7 @@ public static void Example()
// Downloading a few images, and an images.tsv file, which contains a list of the files from the dotnet/machinelearning/test/data/images/.
// If you inspect the fileSystem, after running this line, an "images" folder will be created, containing 4 images, and a .tsv file
// enumerating the images.
var imagesDataFile = SamplesUtils.DatasetUtils.DownloadImages();
var imagesDataFile = Microsoft.ML.SamplesUtils.DatasetUtils.DownloadImages();

// Preview of the content of the images.tsv file
//
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
using System;
using System.IO;
using Microsoft.ML;
using Microsoft.ML.Data;

namespace Microsoft.ML.Samples.Dynamic
namespace Samples.Dynamic
{
public static class ResizeImages
{
@@ -16,7 +17,7 @@ public static void Example()
// Downloading a few images, and an images.tsv file, which contains a list of the files from the dotnet/machinelearning/test/data/images/.
// If you inspect the fileSystem, after running this line, an "images" folder will be created, containing 4 images, and a .tsv file
// enumerating the images.
var imagesDataFile = SamplesUtils.DatasetUtils.DownloadImages();
var imagesDataFile = Microsoft.ML.SamplesUtils.DatasetUtils.DownloadImages();

// Preview of the content of the images.tsv file
//