Fixing namespace for image samples #3208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogancarr
reviewed
Apr 5, 2019
| @@ -15,7 +16,7 @@ public static void Example() | |||
| // Downloading a few images, and an images.tsv file, which contains a list of the files from the dotnet/machinelearning/test/data/images/. | |||
| // If you inspect the fileSystem, after running this line, an "images" folder will be created, containing 4 images, and a .tsv file | |||
| // enumerating the images. | |||
| var imagesDataFile = SamplesUtils.DatasetUtils.DownloadImages(); | |||
| var imagesDataFile = Microsoft.ML.SamplesUtils.DatasetUtils.DownloadImages(); | |||
There was a problem hiding this comment.
Microsoft.ML. [](start = 33, length = 13)
Do you need this? You don't in ConvertToGrayScale.
Ditto for the rest of the files with this pattern. #Resolved
There was a problem hiding this comment.
added to ConvertToGrayScale in iteration 2 (else its compile time error)
In reply to: 272409998 [](ancestors = 272409998)
rogancarr
approved these changes
Apr 5, 2019
abgoswam
added a commit
to abgoswam/machinelearning
that referenced
this pull request
Apr 5, 2019
* fixing namespace for image samples * fix compile error
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #3205