Fix runtime exception in prior trainer sample and update the comments. #3295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wschin
reviewed
Apr 11, 2019
| @@ -63,7 +63,7 @@ public static void Example() | |||
| // Positive Precision: 0.50 | |||
| // Positive Recall: 1.00 | |||
| // LogLoss: 1.05 | |||
| // LogLossReduction: -4.89 | |||
There was a problem hiding this comment.
Why does it change the baseline?
There was a problem hiding this comment.
It didn't the documentation was stale. I verified this without the prior trainer change from the master branch (removed the change that changes label type to boolean) and below is the output:
Accuracy: 0.50
AUC: 0.50
F1 Score: 0.67
Negative Precision: 0.00
Negative Recall: 0.00
Positive Precision: 0.50
Positive Recall: 1.00
Log Loss: 1.05
Log Loss Reduction: -0.05
Entropy: 1.00
wschin
approved these changes
Apr 11, 2019
Codecov Report
@@ Coverage Diff @@
## master #3295 +/- ##
==========================================
- Coverage 72.63% 72.63% -0.01%
==========================================
Files 807 807
Lines 145127 145127
Branches 16219 16219
==========================================
- Hits 105414 105412 -2
- Misses 35295 35298 +3
+ Partials 4418 4417 -1
|
TomFinley
approved these changes
Apr 11, 2019
eerhardt
approved these changes
Apr 11, 2019
…utput in comments.
codemzs
added a commit
to codemzs/machinelearning
that referenced
this pull request
Apr 11, 2019
…utput in comments. (dotnet#3295)
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3294