Skip to content

Fix runtime exception in prior trainer sample and update the comments. #3295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2019
Merged

Fix runtime exception in prior trainer sample and update the comments. #3295

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .../samples/Microsoft.ML.Samples/Dynamic/Trainers/BinaryClassification/PriorTrainerSample.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public static void Example()
var loader = mlContext.Data.CreateTextLoader(
columns: new[]
{
new TextLoader.Column("Sentiment", DataKind.Single, 0),
new TextLoader.Column("Sentiment", DataKind.Boolean, 0),
new TextLoader.Column("SentimentText", DataKind.String, 1)
},
hasHeader: true
Expand Down Expand Up @@ -63,7 +63,7 @@ public static void Example()
// Positive Precision: 0.50
// Positive Recall: 1.00
// LogLoss: 1.05
// LogLossReduction: -4.89
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does it change the baseline?

Copy link
Member Author

@codemzs codemzs Apr 11, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It didn't the documentation was stale. I verified this without the prior trainer change from the master branch (removed the change that changes label type to boolean) and below is the output:

Accuracy: 0.50
AUC: 0.50
F1 Score: 0.67
Negative Precision: 0.00
Negative Recall: 0.00
Positive Precision: 0.50
Positive Recall: 1.00
Log Loss: 1.05
Log Loss Reduction: -0.05
Entropy: 1.00

// LogLossReduction: -0.05
// Entropy: 1.00
}
}
Expand Down