Tom cherry pick #3315
Closed
Tom cherry pick #3315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Key type documentation.
* Update IDataView principles, type system documentation.
…torDataViewType documentation. (dotnet#3296)
TomFinley
requested review from
shauheen,
eerhardt,
sfilipi,
glebuk and
shmoradims
shauheen
approved these changes
Apr 12, 2019
|
Done as part of #3333 . Thanks @TomFinley . |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of some of my commits into release/1.0. Which PRs they correspond to is obvious from the commit descriptions. Only one, the last one, required conflict resolution. I have verified the sample introduced still runs.
Note also that when I run the test locally, the test
EntryPointLinearPredictorSummaryfails. This appears to have nothing to do with my changes, but it is probably something that shiproom should be aware of. @shauheen , @glebuk .