-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Update release branch #3333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Update release branch #3333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trainers (dotnet#3104) * fixed issue, added tests * fix review comments * updating equality checks for floats
* Improve VBuffer documentation. * Improve the XML documentation for VBuffer/VBufferEditor. * Update the "best practices" documentation to reflect recent changes. * Update parameter names to avoid abbreviations, e.g., src => source and suchlike.
…d remove Normalizer generic APIs (dotnet#3118) * Move Normalizer extension method from experimental to stable nuget. * Cleanup unused method in Normalizer Estimator. * remove normalizer estimator catalog methods that take enum as parameter. * Remove Microsoft.ML.Experimental references in CS files. * merge fix. * cleanup. * cleanup. * PR feedback.
* Adding release notes for RC1
When doing an official build and setting a AzDO build variable, the variable turns into an environment variable. When MSBuild props/targets files declare a property, if they don't check if the property is already set, the MSBuild props file will override the environment variable. This causes the AzDO build variable to be ignored. Adding a check if the IncludeBuildNumberInPackageVersion property is already set before setting it in Directory.Build.props.
* Multi-column mapping for Normalizer estimators. * XML comment. * revert Program.cs * Add copyright header. * Add tests. * PR feedback. * cleanup. * PR feedback.
…3165) * updating image samples * fix review comments (print preview) * fix comments (minor nits) * fix review comments (whitespaces)
* adding a sample for convert MultiColumns. Moving files around. * Adjust the samples about ValueMapping * Addressing PR comments
* Key type documentation.
* categorical transform estimators * review comments * fix review comments * modify samples namespace
* samples for FeatureSelection transform estimators * fix review comments * fix review comments * review comments * take care of review comments * fix copy paste output error
* Try buiid omp again * Add LIBMF's fix
…utput in comments. (dotnet#3295)
…torDataViewType documentation. (dotnet#3296)
* Adding Regression and Binary Classification GAM samples.
# Conflicts: # build/BranchInfo.props # docs/samples/Microsoft.ML.Samples/Dynamic/DataOperations/BootstrapSample.cs # docs/samples/Microsoft.ML.Samples/Dynamic/Normalizer.cs # docs/samples/Microsoft.ML.Samples/Dynamic/PermutationFeatureImportance/PFIRegressionExample.cs # docs/samples/Microsoft.ML.Samples/Dynamic/PermutationFeatureImportance/PfiBinaryClassificationExample.cs # docs/samples/Microsoft.ML.Samples/Dynamic/Trainers/BinaryClassification/StochasticDualCoordinateAscentNonCalibrated.cs # src/Microsoft.ML.Transforms/NormalizerCatalog.cs
Awesome! |
eerhardt
approved these changes
Apr 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked through all the high-level folder changes and at each change to files in the src
folder. This looks good to me.
TomFinley
approved these changes
Apr 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you good sir.
This was referenced Apr 14, 2019
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the 1.0 release branch with changes from Master branch.