Skip to content

Update release branch #3333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 73 commits into from
Apr 14, 2019
Merged

Update release branch #3333

merged 73 commits into from
Apr 14, 2019

Conversation

shauheen
Copy link
Contributor

This PR updates the 1.0 release branch with changes from Master branch.

shauheen and others added 30 commits March 26, 2019 11:06
…trainers (dotnet#3104)

* fixed issue, added tests

* fix review comments

* updating equality checks for floats
* Improve VBuffer documentation.
* Improve the XML documentation for VBuffer/VBufferEditor.
* Update the "best practices" documentation to reflect recent changes.
* Update parameter names to avoid abbreviations, e.g., src => source and suchlike.
…d remove Normalizer generic APIs (dotnet#3118)

* Move Normalizer extension method from experimental to stable nuget.

* Cleanup unused method in Normalizer Estimator.

* remove normalizer estimator catalog methods that take enum as parameter.

* Remove Microsoft.ML.Experimental references in CS files.

* merge fix.

* cleanup.

* cleanup.

* PR feedback.
* Adding release notes for RC1
When doing an official build and setting a AzDO build variable, the variable turns into an environment variable. When MSBuild props/targets files declare a property, if they don't check if the property is already set, the MSBuild props file will override the environment variable. This causes the AzDO build variable to be ignored.

Adding a check if the IncludeBuildNumberInPackageVersion property is already set before setting it in Directory.Build.props.
* Multi-column mapping for Normalizer estimators.

* XML comment.

* revert Program.cs

* Add copyright header.

* Add tests.

* PR feedback.

* cleanup.

* PR feedback.
…3165)

* updating image samples

* fix review comments (print preview)

* fix comments (minor nits)

* fix review comments (whitespaces)
* adding a sample for convert MultiColumns. Moving files around.

* Adjust the samples about ValueMapping

* Addressing PR comments
* Key type documentation.
* categorical transform estimators

* review comments

* fix review comments

* modify samples namespace
* samples for FeatureSelection transform estimators

* fix review comments

* fix review comments

* review comments

* take care of review comments

* fix copy paste output error
wschin and others added 9 commits April 11, 2019 15:03
* Try buiid omp again

* Add LIBMF's fix
* Adding Regression and Binary Classification GAM samples.
# Conflicts:
#	build/BranchInfo.props
#	docs/samples/Microsoft.ML.Samples/Dynamic/DataOperations/BootstrapSample.cs
#	docs/samples/Microsoft.ML.Samples/Dynamic/Normalizer.cs
#	docs/samples/Microsoft.ML.Samples/Dynamic/PermutationFeatureImportance/PFIRegressionExample.cs
#	docs/samples/Microsoft.ML.Samples/Dynamic/PermutationFeatureImportance/PfiBinaryClassificationExample.cs
#	docs/samples/Microsoft.ML.Samples/Dynamic/Trainers/BinaryClassification/StochasticDualCoordinateAscentNonCalibrated.cs
#	src/Microsoft.ML.Transforms/NormalizerCatalog.cs
@codemzs
Copy link
Member

codemzs commented Apr 13, 2019

Awesome!

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked through all the high-level folder changes and at each change to files in the src folder. This looks good to me.

Copy link
Contributor

@TomFinley TomFinley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you good sir.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.