API reference - Fix placeholder links #3359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3359 +/- ##
==========================================
- Coverage 72.69% 72.69% -0.01%
==========================================
Files 807 807
Lines 145172 145172
Branches 16225 16225
==========================================
- Hits 105540 105539 -1
- Misses 35218 35220 +2
+ Partials 4414 4413 -1
|
singlis
reviewed
Apr 17, 2019
| @@ -21,7 +21,7 @@ namespace Microsoft.ML.Trainers | |||
| public abstract class AveragedLinearOptions : OnlineLinearOptions | |||
| { | |||
| /// <summary> | |||
| /// <a href="tmpurl_lr">Learning rate</a>. | |||
| /// Learning rate. | |||
There was a problem hiding this comment.
Should there be the uri here for what tempurl_lr referenced?
|
@shmoradims I have one comment to review, but it does look good. I am a little confused on why we are replacing the tempurl with the actual link when it looks like in 2356 the point is to use the tempurl. |
wschin
reviewed
Apr 17, 2019
| @@ -61,7 +61,7 @@ public abstract class AveragedLinearOptions : OnlineLinearOptions | |||
| public bool LazyUpdate = true; | |||
|
|
|||
| /// <summary> | |||
| /// The L2 weight for <a href='tmpurl_regularization'>regularization</a>. | |||
| /// The L2 weight for <a href='https://en.wikipedia.org/wiki/Regularization_(mathematics)'>regularization</a>. | |||
There was a problem hiding this comment.
Suggested change
| /// The L2 weight for <a href='https://en.wikipedia.org/wiki/Regularization_(mathematics)'>regularization</a>. | |
| /// The coefficient of L2-norm for <a href='https://en.wikipedia.org/wiki/Regularization_(mathematics)'>regularization on the weight vector</a>. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2356 with actual links.