Remove Extra Code Comments and unused InternalStreams project #514

dan-drews · 2018-07-10T03:09:58Z

Fixes #513

This is the first go-around at finding extra commented code sitting around. I'll circle back on more when I have a chance.

TomFinley · 2018-07-10T17:27:30Z

test/Microsoft.ML.Core.Tests/UnitTests/TestEntryPoints.cs

@@ -201,55 +201,6 @@ public void EntryPointCaching()
            Done();
        }

-        //[Fact]


Hi @dan-drews thanks for looking at this. One thing I wonder about is, should this be uncommented and turn into a fact-skip? Or is the code just too far gone for that? (I might suspect some of the names may have changed.)

Thanks @TomFinley I'll take a look. Should my rule of thumb be that if it compiles, I leave it as fact-skip, otherwise I remove it? I could try to see what things are renamed to, but I'm still not super familiar with this project yet

Edit: Upon further review, there are references to a class called Dv1. That appears not to exist anymore.

Unfortunately some classes have been renamed in the leadup to the public release a couple months ago. If it's not obvious how to do it, I would prefer that you leave the commented out code there, rather than destroy the test, since I think I know how "reanimate" this test. (E.g., Dv1 I think is DvInt1, etc. etc.) So while the main codebase I think could use with cleaning, something like this I might prefer to review more carefully. Maybe not cut this one?

It may be that it's appropriate to remove it, but I'd prefer to do so in a more deliberative way.

In reply to: 201912980 [](ancestors = 201912980)

I have re-added those tests, and just left them commented out. I tried to simply change Dv1 to DvInt1, but the parameters are different. I'd rather somebody with a greater understanding of what is going on here dig through it. Thanks for the feedback!

TomFinley · 2018-07-10T17:28:36Z

            public uint /*ulong*/ /*IntPtr*/ /*NTSTATUS*/ Status;

I think this and the other line are some things we may consider removing.

Refers to: src/Microsoft.ML.InternalStreams/InternalStreams.cs:271 in 8886bd8. [](commit_id = 8886bd8, deletion_comment = False)

TomFinley · 2018-07-10T17:28:41Z

                Status = 0; //IntPtr.Zero;

As is this.

Refers to: src/Microsoft.ML.InternalStreams/InternalStreams.cs:276 in 8886bd8. [](commit_id = 8886bd8, deletion_comment = False)

dan-drews · 2018-07-10T23:29:13Z

Removed WIP tag. I'm sure there are more comments to be removed, but I think this was a pretty good sweep.

Ivanidzo4ka · 2018-07-11T16:51:40Z

src/Microsoft.ML.FastTree/Application/LogLossApplication.cs

-                                            _gradient[d2] -= 0.01 * labelDiff;
-                                        }
-                    */
+                    _gradient[d2] -= delta;                    


[](start = 43, length = 20)

can you format this file in VS? or at least remove all extra spaces here. #Resolved

Ivanidzo4ka · 2018-07-11T16:53:31Z

    private ParameterSet[] TreeOrderedCandidatesSearch(FastForestRegressionPredictor forest, int numOfCandidates, IEnumerable<IRunResult> previousRuns)

Feel free to delete whole function, no one calls it anyway. #Closed

Refers to: src/Microsoft.ML.Sweeper/Algorithms/SmacSweeper.cs:185 in 97290b2. [](commit_id = 97290b2, deletion_comment = False)

Ivanidzo4ka · 2018-07-11T16:55:28Z

src/Microsoft.ML.StandardLearners/FactorizationMachine/FactorizationMachineInterface.cs


        [DllImport(NativePath), SuppressUnmanagedCodeSecurity]
        public static extern void CalculateGradientAndUpdateNative(float lambdaLinear, float lambdaLatent, float learningRate, int fieldCount, int latentDim, float weight,
-            int count, int* /*const*/ fieldIndices, int* /*const*/ featureIndices, float* /*const*/ featureValues, float* /*const*/ latentSum, float slope,
+            int count, int* fieldIndices, int* featureIndices, float* featureValues, float* latentSum, float slope,


#383 (comment)
See @wschin comment.
I agree this is not the best solution, but I would prefer to preserve this information until we figure out better one.
Same states for Thunk.cs.

We have them for a reason.
#Resolved

Ivanidzo4ka · 2018-07-11T16:57:52Z

Thank you for your work @dan-drews !
Can we slightly change name of this PR to address removal of InternalStreams project?

TomFinley · 2018-07-12T05:31:39Z

Microsoft.ML.sln

@@ -36,8 +36,6 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.ML.Tests", "test\
 EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.ML.TestFramework", "test\Microsoft.ML.TestFramework\Microsoft.ML.TestFramework.csproj", "{B5989C06-4FFA-46C1-9D85-9366B34AB0A2}"
 EndProject
-Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.ML.InternalStreams", "src\Microsoft.ML.InternalStreams\Microsoft.ML.InternalStreams.csproj", "{C4F7938F-7109-43C8-92A5-9BE47C7FF7D9}"


🎆 🍾 😆 Good riddance!!

TomFinley · 2018-07-12T05:33:25Z

src/Microsoft.ML.Core/Utilities/MathUtils.cs

-            //  return SoftMax(inputs[0], inputs[1]);
-            //}
-
+


Blank line with space on it introduced.

Is the blank line okay as long as the whitespace is removed?That matches the if statement above.

Also, for my own reference, how can you tell there is whitespace? Is it through Visual Studio? Or is there also a way to know through github?

TomFinley · 2018-07-12T05:36:19Z

test/Microsoft.ML.Core.Tests/UnitTests/TestEntryPoints.cs

@@ -600,63 +551,6 @@ public void EntryPointExecGraphCommand()
            cmd.Run();
        }

-        //[Fact]
-        //public void EntryPointArrayOfVariables()


//public void EntryPointArrayOfVariables() [](start = 8, length = 42)

Similar with this.

TomFinley

Thanks @dan-drews ! I think the builds are failing due to #428 commit, but once #527 goes in we can request a rebuild...

Ivanidzo4ka · 2018-07-13T18:23:40Z

@dotnet-bot test Windows_NT Debug
@dotnet-bot test Windows_NT Release
@dotnet-bot test OSX10.13 Debug
@dotnet-bot test OSX10.13 Release
@dotnet-bot test Linux Debug
@dotnet-bot test Linux Release

Ivanidzo4ka

@Ivanidzo4ka

…#514) * First attempt at removing extra code comments * Round #2 * Removing Microsoft.ML.InternalStreams per comment on dotnet#513 * Address notes from @Ivanidzo4ka * Remove TreeOrderedCandidatesSearch * Remove whitespace and reinstate commented out tests

First attempt at removing extra code comments

8886bd8

TomFinley reviewed Jul 10, 2018

View reviewed changes

Round #2

b635e93

dan-drews changed the title ~~WIP Remove Extra Code Comments~~ Remove Extra Code Comments Jul 10, 2018

Removing Microsoft.ML.InternalStreams per comment on #513

97290b2

Ivanidzo4ka reviewed Jul 11, 2018

View reviewed changes

dan-drews changed the title ~~Remove Extra Code Comments~~ Remove Extra Code Comments and unused InternalStreams project Jul 11, 2018

Daniel Drews added 2 commits July 11, 2018 19:05

Address notes from @Ivanidzo4ka

1b1e5bb

Remove TreeOrderedCandidatesSearch

7bcd0a6

TomFinley reviewed Jul 12, 2018

View reviewed changes

shauheen requested a review from codemzs July 12, 2018 09:39

Remove whitespace and reinstate commented out tests

d41d116

dan-drews changed the title ~~Remove Extra Code Comments and unused InternalStreams project~~ [WIP] Remove Extra Code Comments and unused InternalStreams project Jul 13, 2018

dan-drews changed the title ~~[WIP] Remove Extra Code Comments and unused InternalStreams project~~ Remove Extra Code Comments and unused InternalStreams project Jul 13, 2018

TomFinley approved these changes Jul 13, 2018

View reviewed changes

Ivanidzo4ka approved these changes Jul 13, 2018

View reviewed changes

Ivanidzo4ka merged commit 669f4fa into dotnet:master Jul 13, 2018

ghost locked as resolved and limited conversation to collaborators Mar 30, 2022

Remove Extra Code Comments and unused InternalStreams project #514

Remove Extra Code Comments and unused InternalStreams project #514

Uh oh!

Conversation

dan-drews commented Jul 10, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dan-drews Jul 10, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TomFinley commented Jul 10, 2018

Uh oh!

TomFinley commented Jul 10, 2018

Uh oh!

dan-drews commented Jul 10, 2018

Uh oh!

Ivanidzo4ka Jul 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Ivanidzo4ka commented Jul 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ivanidzo4ka Jul 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Ivanidzo4ka commented Jul 11, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TomFinley left a comment

Choose a reason for hiding this comment

Uh oh!

Ivanidzo4ka commented Jul 13, 2018

Uh oh!

Ivanidzo4ka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dan-drews Jul 10, 2018 •

edited

Loading

Ivanidzo4ka Jul 11, 2018 •

edited

Loading

Ivanidzo4ka commented Jul 11, 2018 •

edited

Loading

Ivanidzo4ka Jul 11, 2018 •

edited

Loading