Convert ML.Sweeper usages of SubComponent to IComponentFactory. #734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eerhardt
requested review from
codemzs,
Ivanidzo4ka,
TomFinley,
abgoswam and
Zruty0
codemzs
reviewed
Aug 29, 2018
| @@ -193,13 +194,13 @@ public sealed class Arguments | |||
| public DeterministicSweeperAsync(IHostEnvironment env, Arguments args) | |||
| { | |||
| _host = env.Register("DeterministicSweeperAsync", args.RandomSeed); | |||
| _host.CheckUserArg(args.Sweeper.IsGood(), nameof(args.Sweeper), "Please specify a sweeper"); | |||
| _host.CheckValue(args.Sweeper, nameof(args.Sweeper), "Please specify a sweeper"); | |||
There was a problem hiding this comment.
CheckValue [](start = 18, length = 10)
why is this changed to CheckValue from CheckUserArgs?
There was a problem hiding this comment.
SubComponents have an IsGood() extension method that check both for null and for a non-empty "Kind" property. CheckUserArg only has an overload for bool, which IsGood() returns.
Now that this is an IComponentFactory, the only thing we can check for is null - which is what CheckValue does.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving all the SubComponent usages in the ML.Sweeper assembly to use IComponentFactory.
Note: I logged #733 for the NelderMeadSweeper, which was using another component that doesn't appear to be in the
dotnet/machinelearningrepo.Working towards #585