Skip to content

Misc SubComponent removals #773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 5, 2018
Merged

Misc SubComponent removals #773

merged 3 commits into from
Sep 5, 2018

Conversation

eerhardt
Copy link
Member

Removing SubComponent usages in:

  • ML.Maml
  • ComponentCreation extension methods

After this change the only places that use SubComponents are:

  1. CmdParser.cs, SubComponent.cs, and ComponentCatalog.cs (which will be the last things to be removed).
  2. PipelineInference (which the whole project will be removed from this repo with Consider removing Sweeper, PipelineInference, and ResultProcessor assemblies from Microsoft.ML nuget #689)
  3. EntryPoint code gen (which should no longer apply since there are no more usages of SubComponents in the API)
  4. Tests

Working towards #585

TomFinley
TomFinley approved these changes Aug 30, 2018
View reviewed changes
Copy link
Contributor

@TomFinley TomFinley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @eerhardt !

Ivanidzo4ka
Ivanidzo4ka approved these changes Sep 4, 2018
View reviewed changes
Copy link
Contributor

@Ivanidzo4ka Ivanidzo4ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@eerhardt eerhardt merged commit fb08811 into dotnet:master Sep 5, 2018
@eerhardt eerhardt deleted the MamlSubComponents branch September 5, 2018 01:28
@ghost ghost locked as resolved and limited conversation to collaborators Mar 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ivanidzo4ka Ivanidzo4ka Ivanidzo4ka approved these changes

@TomFinley TomFinley TomFinley approved these changes

@codemzs codemzs Awaiting requested review from codemzs

@Zruty0 Zruty0 Awaiting requested review from Zruty0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eerhardt @Ivanidzo4ka @TomFinley