Skip to content

Remove SubComponent usage from ML.PipelineInference. #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 8, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/Microsoft.ML.PipelineInference/ExperimentsGenerator.cs
Original file line number Diff line number Diff line change
@@ -112,7 +112,14 @@ public static List<Sweep> GenerateCandidates(IHostEnvironment env, string dataFi
// Exclude the hidden learners, and the metalinear learners.
var trainers = ComponentCatalog.GetAllDerivedClasses(typeof(ITrainer), predictorType).Where(cls => !cls.IsHidden);

string loader = $" loader=TextLoader{{{loaderSettings}}}";
if (!string.IsNullOrEmpty(loaderSettings))
{
StringBuilder sb = new StringBuilder();
CmdQuoter.QuoteValue(loaderSettings, sb, true);
loaderSettings = sb.ToString();
}

string loader = $" loader=TextLoader{loaderSettings}";

// REVIEW: there are more learners than recipes atm.
// Flip looping through recipes, then through learners if the cardinality changes.
2 changes: 1 addition & 1 deletion src/Microsoft.ML.PipelineInference/TransformInference.cs
Original file line number Diff line number Diff line change
@@ -107,7 +107,7 @@ public TransformString(string kind, string settings)
public bool Equals(TransformString other)
{
return Kind == other.Kind &&
Settings.Equals(other.Settings);
Settings == other.Settings;
}

public override string ToString()