Remove SubComponent usage from ML.PipelineInference. #817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
codemzs
reviewed
Sep 6, 2018
| public bool Equals(TransformString other) | ||
| { | ||
| return Kind == other.Kind && | ||
| Settings.Equals(other.Settings); |
There was a problem hiding this comment.
Can we please be consistent with equality comparison syntax?
There was a problem hiding this comment.
Oops - yes. Good catch. This was first taken from SubComponent, where Settings is an array. Fixing.
Working towards dotnet#585
eerhardt
force-pushed
the
PipelineInference
branch
from
86d4ade to
47894d1
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working towards #585