Skip to content

Minor comment fixes. #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2018
Merged

Minor comment fixes. #84

merged 1 commit into from
May 8, 2018

Conversation

jessebenson
Copy link
Contributor

@jessebenson jessebenson commented May 8, 2018 •
edited by Ivanidzo4ka
Loading

Minor comment fixes (typos and references non-existent files) in the Native code.

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

@dnfclas
Copy link

dnfclas commented May 8, 2018 •
edited
Loading

CLA assistant check
All CLA requirements met.

Ivanidzo4ka
Ivanidzo4ka approved these changes May 8, 2018
View reviewed changes
Copy link
Contributor

@Ivanidzo4ka Ivanidzo4ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@shauheen shauheen self-requested a review May 8, 2018 21:52
@shauheen shauheen merged commit 142f3d7 into dotnet:master May 8, 2018
@shauheen
Copy link
Contributor

shauheen commented May 9, 2018

Thanks @jessebenson for your contribution.

eerhardt pushed a commit to eerhardt/machinelearning that referenced this pull request Jul 27, 2018
@jessebenson @eerhardt
Minor comment fixes. (dotnet#84)
516c824
@ghost ghost locked as resolved and limited conversation to collaborators Mar 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ivanidzo4ka Ivanidzo4ka Ivanidzo4ka approved these changes

@shauheen shauheen shauheen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jessebenson @dnfclas @shauheen @Ivanidzo4ka