Skip to content

Minor comment fixes. #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2018
Merged

Minor comment fixes. #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Native/FastTreeNative/ExpandFloatType.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@
#include "SumupOneBit.h"

// Ideally we should expand this using C++ templates.
// However, In order to exporting functions from DLL float and double versions need to have different names (cannot be overloaded on type parameters)// Expanding here with ugly pre-processor macros to get double and float versions (with fucntion mes suffixes _float and _double)
// However, in order to export functions from DLL, float and double versions need to have different names (cannot be overloaded on type parameters)
// Expanding here with ugly pre-processor macros to get double and float versions (with function name suffixes _float and _double)
// --andrzejp, 2010-03-05

#define FloatType float
Expand Down
2 changes: 1 addition & 1 deletion src/Native/FastTreeNative/getderivatives.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ EXPORT_API(void) C_GetDerivatives(

bool sameLabel = labelHigh == pLabels[low];

// calculate the lambdaP for this pair by looking it up in the lambdaTable (computed in LambdaMart.FillLambdaTable)
// calculate the lambdaP for this pair by looking it up in the sigmoidTable (e.g. computed in FastTreeRanking.FillSigmoidTable)
double lambdaP;
if (scoreHighMinusLow <= minScore) lambdaP = sigmoidTable[0];
else if (scoreHighMinusLow >= maxScore) lambdaP = sigmoidTable[sigmoidTableLength - 1];
Expand Down