Skip to content

Conversation

akarnokd
Copy link
Collaborator

@akarnokd akarnokd commented Dec 4, 2019

This PR adds GitHub templates so new Issues or PRs are welcomed with questions and instructions.

I've tried to incorporate as much OSS support experience (with RxJava and with dotnet/reactive) as I could as politely as seemed reasonable.

Resolves #187

Copy link
Contributor

@clairernovotny clairernovotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! One suggestion is to have different templates for Ix & Rx so that the template can apply a default label too.

@akarnokd
Copy link
Collaborator Author

akarnokd commented Dec 4, 2019

have different templates for

Good idea, not sure how to do it though.

@clairernovotny
Copy link
Contributor

Take a look at the templates in dotnet-foundation/projects

@akarnokd
Copy link
Collaborator Author

akarnokd commented Dec 4, 2019

Done. I didn't split further along bug/enhancement/feature/question because it often requires evaluation (i.e., asked like a question but it is actually a bug).

@danielcweber danielcweber merged commit d35d1f5 into dotnet:master Dec 5, 2019
@akarnokd akarnokd deleted the GithubTemplates branch December 5, 2019 13:37
@akarnokd
Copy link
Collaborator Author

akarnokd commented Dec 5, 2019

The issue template choser works, but the pull request template doesn't. I get a blank PR. Looks like template choser for PRs is not supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add issue & pull request templates to repo
3 participants