Simplify thread pool scheduler timed schedule #633
Conversation
| { | ||
| SpinWait.SpinUntil(timer.IsTimerAssigned); | ||
| timer.Stop(); | ||
| } |
There was a problem hiding this comment.
As far as I understand it, the original code uses here a try-finally-guard to guarantee that the assignment of _timer happens and it waits in the Tick() method, until the _timer is really set. Is this not needed in the new version?
There was a problem hiding this comment.
It's IMO a poor way of achieving synchronization. We can do better in UserWorkItem. If you have a look at UserWorkItem, the backing field of CancelQueueDisposable is only touched by the Disposable-helper methods. These ensure that, no matter what order the calls occur (assignment/disposal or disposal/assignment), we get the desired result. Disposable does it with Interlocked methods.
There was a problem hiding this comment.
Ah, now I understand. so
Disposable.TryDispose(ref _field);
Disposable.TrySetSingle(ref _field, disposable);Will dispose disposable, that's very clever.
…work item on a timer.
No description provided.