Skip to content

Conversation

tomeksowi
Copy link
Member

Increase timeout on CancelKeyPressTests.ExitDetectionNotBlockedByHandler on Debug RISC-V, similar to #96187 or #96186.

Part of #84834, cc @dotnet/samsung

@ghost ghost added the area-System.Console label Aug 8, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Aug 8, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-console
See info in area-owners.md if you want to be subscribed.

@jkotas
Copy link
Member

jkotas commented Aug 8, 2024

The change does not work as expected:

    CancelKeyPressTests.HandlerInvokedForSigInt(redirectStandardInput: False) [FAIL]
      System.ArgumentException : Field marshaling is not supported by Invoke: WaitFailTestTimeoutSeconds
      Stack Trace:
        /_/src/Microsoft.DotNet.RemoteExecutor/src/RemoteExecutor.cs(602,0): at Microsoft.DotNet.RemoteExecutor.RemoteExecutor.GetMethodInfo(Delegate d)
        /_/src/Microsoft.DotNet.RemoteExecutor/src/RemoteExecutor.cs(128,0): at Microsoft.DotNet.RemoteExecutor.RemoteExecutor.Invoke(Action`1 method, String arg, RemoteInvokeOptions options)
        /_/src/libraries/System.Console/tests/CancelKeyPress.Unix.cs(100,0): at CancelKeyPressTests.HandlerInvokedForSignal(Int32 signalOuter, Boolean redirectStandardInput)
        /_/src/libraries/System.Console/tests/CancelKeyPress.Unix.cs(26,0): at CancelKeyPressTests.HandlerInvokedForSigInt(Boolean redirectStandardInput)

@clamp03 clamp03 added the arch-riscv Related to the RISC-V architecture label Aug 8, 2024
@jkotas
Copy link
Member

jkotas commented Aug 9, 2024

/ba-g dead lettered Helix queue

@jkotas jkotas merged commit 7a2763a into dotnet:main Aug 9, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-riscv Related to the RISC-V architecture area-System.Console community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants