Skip to content

[RISC-V] System.Console CancelKeyPressTests.ExitDetectionNotBlockedByHandler increase timeout #106119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 9, 2024
Merged

[RISC-V] System.Console CancelKeyPressTests.ExitDetectionNotBlockedByHandler increase timeout #106119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c17a0c0
Increase timeout to prevent failure of CancelKeyPressTests.ExitDetect…
tomeksowi Aug 8, 2024
832b95f
Make WaitFailTestTimeoutSeconds static, move it closer to where it's …
tomeksowi Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/libraries/System.Console/tests/CancelKeyPress.Unix.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ public void HandlerInvokedForSigQuit(bool redirectStandardInput)
HandlerInvokedForSignal(SIGQUIT, redirectStandardInput);
}

private static readonly int WaitFailTestTimeoutSeconds = 30 * PlatformDetection.SlowRuntimeTimeoutModifier;

[ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
public void ExitDetectionNotBlockedByHandler()
{
Expand Down Expand Up @@ -79,7 +81,10 @@ public void ExitDetectionNotBlockedByHandler()
// Release CancelKeyPress, and give it time to return and tear down the app
mre.Set();
Thread.Sleep(WaitFailTestTimeoutSeconds * 1000);
}, new RemoteInvokeOptions() { ExpectedExitCode = 130 }).Dispose();
}, new RemoteInvokeOptions() {
ExpectedExitCode = 130,
TimeOut = RemoteExecutor.FailWaitTimeoutMilliseconds * PlatformDetection.SlowRuntimeTimeoutModifier
}).Dispose();
}

private void HandlerInvokedForSignal(int signalOuter, bool redirectStandardInput)
Expand Down
2 changes: 0 additions & 2 deletions src/libraries/System.Console/tests/CancelKeyPress.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@

public partial class CancelKeyPressTests
{
private const int WaitFailTestTimeoutSeconds = 30;

[Fact]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
public static void CanAddAndRemoveHandler()
Expand Down