Linux/arm: LSRA resolution issues #109173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f its association with busy lower-half register (dotnet#107714)" This reverts commit f1bcbeb.
…ng resolution (dotnet#107493)" This reverts commit ac4b7c6.
ghost
added
the
area-CodeGen-coreclr
|
/azp run Fuzzlyn |
|
/azp run Antigen |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Fuzzlyn |
|
/azp run Antigen |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Fuzzlyn |
|
/azp run Antigen |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@AndyAyersMS @dotnet/jit-contrib PTAL |
AndyAyersMS
approved these changes
Oct 29, 2024
Not really, for the same reason as #105619 (comment). |
|
No antigen/fuzzlyn failures on linux/arm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #107904
There are few places where if one-half of the double register is freed up, we need to also check if the other half can be freed up, if that is one of the target register for the resolution. We were already doing at one place, but when we do the resolution using temporary register, we should do the same thing. And lastly, the condition I was using to free the other half in #107714 was not sufficient leading to failures which is also fixed in this PR with the same logic.
Fixes: #107841