-
Notifications
You must be signed in to change notification settings - Fork 5.2k
SVE2 API for AddPairwise, AddPairwiseWidening, AddSaturate, AddWide and AddWidening #117188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
AddWide and AddWidening
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
The test template changes look pretty low-risk, but just to make sure we aren't getting the second op arg wrong anywhere, could you please run the other tests using this template (AbsoluteDifferenceWidening*
, AddHighNarrowingEven
, etc)?
Sure, all the tests using this template still pass after the changes Full test log16:19:49.578 Running test: _Sve2_ro::JIT.HardwareIntrinsics.Arm._Sve2.Program.Sve2_AbsoluteDifferenceWideningLower_short_sbyte() Supported ISAs: AdvSimd: True Aes: True ArmBase: True Crc32: True Dp: True Rdm: True Sha1: True Sha256: True Sve: True Sve2: TrueBeginning scenario: RunBasicScenario_UnsafeRead 16:20:07.768 Running test: _Sve2_ro::JIT.HardwareIntrinsics.Arm._Sve2.Program.Sve2_AddHighNarrowingEven_sbyte_short() Beginning scenario: RunBasicScenario_UnsafeRead 6:20:07.926 Running test: _Sve2_ro::JIT.HardwareIntrinsics.Arm._Sve2.Program.Sve2_AddHighNarrowingEven_short_int() |
/ba-g unrelated mono failure |
@dotnet/arm64-contrib @amanasifkhalid @a74nh
Contributing towards #115479