Skip to content

SVE2: Correcting the naming of AddWidening intrinsics #117508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 15, 2025
Merged

SVE2: Correcting the naming of AddWidening intrinsics #117508

merged 2 commits into from
Jul 15, 2025

Conversation

jacob-crawley
Copy link
Contributor

@dotnet/arm64-contrib @amanasifkhalid @a74nh

The AddWidening intrinsics merged as part of #117188 were incorrectly named. This patch corrects the naming of these functions so that they are now in line with the SVE2 API proposal.

Contributing towards #115479

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jul 10, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics
See info in area-owners.md if you want to be subscribed.

This was referenced Jul 10, 2025
Open
Closed
Closed
Closed
Open
Closed
Closed
@a74nh
Copy link
Contributor

a74nh commented Jul 15, 2025

ping @amanasifkhalid

This happened because the list on #115479 is based on the pre-reviewed names. I'll fix the list today.

@a74nh
Copy link
Contributor

a74nh commented Jul 15, 2025

Feel free to put in a separate PR, but AddPairwiseWidening should be AddPairwiseWideningAndAdd

amanasifkhalid
amanasifkhalid approved these changes Jul 15, 2025
View reviewed changes
Copy link
Contributor

@amanasifkhalid amanasifkhalid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amanasifkhalid
Copy link
Contributor

Feel free to put in a separate PR, but AddPairwiseWidening should be AddPairwiseWideningAndAdd

@jacob-crawley did you want to do that here, or should I merge this?

@jacob-crawley
Copy link
Contributor Author

Feel free to put in a separate PR, but AddPairwiseWidening should be AddPairwiseWideningAndAdd

@jacob-crawley did you want to do that here, or should I merge this?

I think it makes sense to do this all in the same PR so I'll make those changes before this is merged

@amanasifkhalid
Copy link
Contributor

/ba-g android-x64 CoreCLR build stuck

@amanasifkhalid amanasifkhalid merged commit 6d7ba36 into dotnet:main Jul 15, 2025
149 of 160 checks passed
This was referenced Jul 16, 2025
Open
Open
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@amanasifkhalid amanasifkhalid amanasifkhalid approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area-System.Runtime.Intrinsics community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacob-crawley @a74nh @amanasifkhalid