Skip to content

[H/3] Failed test experiment #117191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[H/3] Failed test experiment #117191

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8d3ed7c
Add logging
ManickaP Jul 1, 2025
b7b4504
Another try
ManickaP Jul 1, 2025
3664a11
More logging
ManickaP Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
97 changes: 72 additions & 25 deletions src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.MaxResponseHeadersLength.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
using Microsoft.DotNet.XUnitExtensions;
using Xunit;
using Xunit.Abstractions;
using TestUtilities;

namespace System.Net.Http.Functional.Tests
{
Expand Down Expand Up @@ -79,29 +80,52 @@ public async Task LargeSingleHeader_ThrowsException(int maxResponseHeadersLength

await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>
{
using HttpClient client = CreateHttpClient(handler);
try
{
using HttpClient client = CreateHttpClient(handler);

Exception e = await Assert.ThrowsAsync<HttpRequestException>(() => client.GetAsync(uri));
if (!IsWinHttpHandler)
Console.WriteLine($"{DateTime.UtcNow:HH:mm:ss.fffffff} LargeSingleHeader_ThrowsException({maxResponseHeadersLength}) - Client before GET");
Exception e = await Assert.ThrowsAsync<HttpRequestException>(() => client.GetAsync(uri));
if (!IsWinHttpHandler)
{
Assert.Contains((handler.MaxResponseHeadersLength * 1024).ToString(), e.ToString());
}
Console.WriteLine($"{DateTime.UtcNow:HH:mm:ss.fffffff} LargeSingleHeader_ThrowsException({maxResponseHeadersLength}) - Client after GET");
await semaphore.WaitAsync();
Console.WriteLine($"{DateTime.UtcNow:HH:mm:ss.fffffff} LargeSingleHeader_ThrowsException({maxResponseHeadersLength}) - Client semaphore DONE");
}
catch (Exception ex)
{
Assert.Contains((handler.MaxResponseHeadersLength * 1024).ToString(), e.ToString());
Console.WriteLine($"{DateTime.UtcNow:HH:mm:ss.fffffff} LargeSingleHeader_ThrowsException({maxResponseHeadersLength}) - Client error: " + ex);
}
await semaphore.WaitAsync();
},
async server =>
{
Console.WriteLine($"{DateTime.UtcNow:HH:mm:ss.fffffff} LargeSingleHeader_ThrowsException({maxResponseHeadersLength}) - Server before request");
try
{
await server.HandleRequestAsync(headers: new[] { new HttpHeaderData("Foo", new string('a', handler.MaxResponseHeadersLength * 1024)) });
}
// Client can respond by closing/aborting the underlying stream while we are still sending the headers, ignore these exceptions
catch (IOException ex) when (ex.InnerException is SocketException se && se.SocketErrorCode == SocketError.Shutdown) { }
catch (IOException ex) when (ex.InnerException is SocketException se && se.SocketErrorCode == SocketError.Shutdown)
{
Console.WriteLine($"{DateTime.UtcNow:HH:mm:ss.fffffff} LargeSingleHeader_ThrowsException({maxResponseHeadersLength}) - Expected server error: " + ex);
}
#if !WINHTTPHANDLER_TEST
catch (QuicException ex) when (ex.QuicError == QuicError.StreamAborted && ex.ApplicationErrorCode == Http3ExcessiveLoad) {}
catch (QuicException ex) when (ex.QuicError == QuicError.StreamAborted && ex.ApplicationErrorCode == Http3ExcessiveLoad)
{
Console.WriteLine($"{DateTime.UtcNow:HH:mm:ss.fffffff} LargeSingleHeader_ThrowsException({maxResponseHeadersLength}) - Expected server error: " + ex);
}
#endif
catch (Exception ex)
{
Console.WriteLine($"{DateTime.UtcNow:HH:mm:ss.fffffff} LargeSingleHeader_ThrowsException({maxResponseHeadersLength}) - Server error: " + ex);
}
finally
{
Console.WriteLine($"{DateTime.UtcNow:HH:mm:ss.fffffff} LargeSingleHeader_ThrowsException({maxResponseHeadersLength}) - Server after request");
semaphore.Release();
Console.WriteLine($"{DateTime.UtcNow:HH:mm:ss.fffffff} LargeSingleHeader_ThrowsException({maxResponseHeadersLength}) - Server semaphore RELEASED");
}
});
}
Expand All @@ -117,28 +141,38 @@ public async Task ThresholdExceeded_ThrowsException(int? maxResponseHeadersLengt
var semaphore = new SemaphoreSlim(0);
await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>
{
using HttpClientHandler handler = CreateHttpClientHandler();

if (maxResponseHeadersLength.HasValue)
try
{
handler.MaxResponseHeadersLength = maxResponseHeadersLength.Value;
}
using HttpClientHandler handler = CreateHttpClientHandler();

using HttpClient client = CreateHttpClient(handler);
if (maxResponseHeadersLength.HasValue)
{
handler.MaxResponseHeadersLength = maxResponseHeadersLength.Value;
}

if (headersLengthEstimate < handler.MaxResponseHeadersLength * 1024L)
{
await client.GetAsync(uri);
}
else
{
Exception e = await Assert.ThrowsAsync<HttpRequestException>(() => client.GetAsync(uri));
if (!IsWinHttpHandler)
using HttpClient client = CreateHttpClient(handler);

Console.WriteLine($"{DateTime.UtcNow:HH:mm:ss.fffffff} ThresholdExceeded_ThrowsException({maxResponseHeadersLength}, {headersLengthEstimate}) - Client before GET");
if (headersLengthEstimate < handler.MaxResponseHeadersLength * 1024L)
{
Assert.Contains((handler.MaxResponseHeadersLength * 1024).ToString(), e.ToString());
await client.GetAsync(uri);
}
else
{
Exception e = await Assert.ThrowsAsync<HttpRequestException>(() => client.GetAsync(uri));
if (!IsWinHttpHandler)
{
Assert.Contains((handler.MaxResponseHeadersLength * 1024).ToString(), e.ToString());
}
}
Console.WriteLine($"{DateTime.UtcNow:HH:mm:ss.fffffff} ThresholdExceeded_ThrowsException({maxResponseHeadersLength}, {headersLengthEstimate}) - Client after GET");
await semaphore.WaitAsync();
Console.WriteLine($"{DateTime.UtcNow:HH:mm:ss.fffffff} ThresholdExceeded_ThrowsException({maxResponseHeadersLength}, {headersLengthEstimate}) - Client semaphore DONE");
}
catch (Exception ex)
{
Console.WriteLine($"{DateTime.UtcNow:HH:mm:ss.fffffff} ThresholdExceeded_ThrowsException({maxResponseHeadersLength}, {headersLengthEstimate}) - Client error: " + ex);
}
await semaphore.WaitAsync();
},
async server =>
{
Expand All @@ -148,18 +182,31 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>
headers.Add(new HttpHeaderData($"Custom-{i}", new string('a', 480)));
}

Console.WriteLine($"{DateTime.UtcNow:HH:mm:ss.fffffff} ThresholdExceeded_ThrowsException({maxResponseHeadersLength}, {headersLengthEstimate}) - Server before request");
try
{
await server.HandleRequestAsync(headers: headers);
}
// Client can respond by closing/aborting the underlying stream while we are still sending the headers, ignore these exceptions
catch (IOException ex) when (ex.InnerException is SocketException se && se.SocketErrorCode == SocketError.Shutdown) { }
catch (IOException ex) when (ex.InnerException is SocketException se && se.SocketErrorCode == SocketError.Shutdown)
{
Console.WriteLine($"{DateTime.UtcNow:HH:mm:ss.fffffff} ThresholdExceeded_ThrowsException({maxResponseHeadersLength}, {headersLengthEstimate}) - Expected server error: " + ex);
}
#if !WINHTTPHANDLER_TEST
catch (QuicException ex) when (ex.QuicError == QuicError.StreamAborted && ex.ApplicationErrorCode == Http3ExcessiveLoad) {}
catch (QuicException ex) when (ex.QuicError == QuicError.StreamAborted && ex.ApplicationErrorCode == Http3ExcessiveLoad)
{
Console.WriteLine($"{DateTime.UtcNow:HH:mm:ss.fffffff} ThresholdExceeded_ThrowsException({maxResponseHeadersLength}, {headersLengthEstimate}) - Expected server error: " + ex);
}
#endif
catch (Exception ex)
{
Console.WriteLine($"{DateTime.UtcNow:HH:mm:ss.fffffff} ThresholdExceeded_ThrowsException({maxResponseHeadersLength}, {headersLengthEstimate}) - Server error: " + ex);
}
finally
{
Console.WriteLine($"{DateTime.UtcNow:HH:mm:ss.fffffff} ThresholdExceeded_ThrowsException({maxResponseHeadersLength}, {headersLengthEstimate}) - Server after request");
semaphore.Release();
Console.WriteLine($"{DateTime.UtcNow:HH:mm:ss.fffffff} ThresholdExceeded_ThrowsException({maxResponseHeadersLength}, {headersLengthEstimate}) - Server semaphore RELEASED");
}
});
}
Expand Down
Loading