[interp] Fixes for Vector3 Interop test #119025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
Fix contract violations in getClassAlignmentRequirement Basic implementation of CPOBJ in the interpreter Implement initblk in the interpreter
kg
force-pushed
the
interp-vector3interop-2
branch
from
c32449a to
aa81ad5
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR implements fixes for Vector3 interop tests in the CoreCLR interpreter by addressing several critical issues. The changes focus on fixing alignment requirement checks and implementing missing IL opcodes that are needed for proper Vector3 interop functionality.
Key changes include:
- Fixing contract violations in
getClassAlignmentRequirementby changing from leaf to non-leaf transitions - Implementing the
CPOBJIL opcode for copying objects by value - Implementing the
INITBLKIL opcode for initializing memory blocks
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/coreclr/vm/jitinterface.cpp | Updates contract declarations and transitions for getClassAlignmentRequirement to handle potential GC triggers |
| src/coreclr/vm/interpexec.cpp | Adds execution logic for the INTOP_INITBLK operation with null reference checking |
| src/coreclr/interpreter/intops.def | Defines the new INTOP_INITBLK opcode in the interpreter operations table |
| src/coreclr/interpreter/compiler.cpp | Implements compilation logic for CEE_CPOBJ and CEE_INITBLK IL opcodes, plus fixes type conversion for localloc |
This was referenced Aug 23, 2025
BrzVlad
reviewed
Aug 25, 2025
jkotas
reviewed
Aug 26, 2025
64 tasks
jkotas
reviewed
Aug 26, 2025
…ments from getClassAlignmentRequirement
jkotas
reviewed
Aug 26, 2025
jkotas
approved these changes
Aug 26, 2025
Co-authored-by: Jan Kotas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these fixes and the fixes from #119020, JIT\SIMD\Vector3Interop_ro\Vector3Interop_ro gets to
All PInvoke testcases passednow. The reverse p/invoke test cases don't pass yet, still.