Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 30 additions & 1 deletion src/coreclr/interpreter/compiler.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3938,6 +3938,18 @@ void InterpCompiler::GenerateCode(CORINFO_METHOD_INFO* methodInfo)
break;
}

case CEE_CPOBJ:
{
CHECK_STACK(2);
CORINFO_RESOLVED_TOKEN resolvedToken;
ResolveToken(getU4LittleEndian(m_ip + 1), CORINFO_TOKENKIND_Class, &resolvedToken);
InterpType interpType = GetInterpType(m_compHnd->asCorInfoType(resolvedToken.hClass));
EmitLdind(interpType, resolvedToken.hClass, 0);
EmitStind(interpType, resolvedToken.hClass, 0, false);
m_ip += 5;
break;
}

case CEE_RET:
{
CORINFO_SIG_INFO sig = methodInfo->args;
Expand Down Expand Up @@ -5500,7 +5512,9 @@ void InterpCompiler::GenerateCode(CORINFO_METHOD_INFO* methodInfo)
// Length is natural unsigned int
if (m_pStackPointer[-1].type == StackTypeI4)
{
EmitConv(m_pStackPointer - 1, StackTypeI8, INTOP_MOV_8);
// The localloc instruction allocates size (type native unsigned int or U4) bytes from the local dynamic memory pool ...
// So the size is currently U4 and needs to be promoted to U8
EmitConv(m_pStackPointer - 1, StackTypeI8, INTOP_CONV_U8_U4);
m_pStackPointer[-1].type = StackTypeI8;
}
#endif
Expand Down Expand Up @@ -5615,6 +5629,21 @@ void InterpCompiler::GenerateCode(CORINFO_METHOD_INFO* methodInfo)
m_ip += 5;
break;
}
case CEE_INITBLK:
{
if (volatile_)
{
AddIns(INTOP_MEMBAR);
volatile_ = false;
}

CHECK_STACK(3);
AddIns(INTOP_INITBLK);
m_pStackPointer -= 3;
m_pLastNewIns->SetSVars3(m_pStackPointer[0].var, m_pStackPointer[1].var, m_pStackPointer[2].var);
m_ip++;
break;
}
case CEE_CPBLK:
CHECK_STACK(3);
if (volatile_)
Expand Down
1 change: 1 addition & 0 deletions src/coreclr/interpreter/intops.def
Original file line number Diff line number Diff line change
Expand Up @@ -397,6 +397,7 @@ OPDEF(INTOP_GENERICLOOKUP, "generic", 4, 1, 1, InterpOpGenericLookup)
OPDEF(INTOP_CALL_FINALLY, "call.finally", 2, 0, 0, InterpOpBranch)

OPDEF(INTOP_ZEROBLK_IMM, "zeroblk.imm", 3, 0, 1, InterpOpInt)
OPDEF(INTOP_INITBLK, "initblk", 4, 0, 3, InterpOpNoArgs)
OPDEF(INTOP_CPBLK, "cpblk", 4, 0, 3, InterpOpNoArgs)
OPDEF(INTOP_LOCALLOC, "localloc", 3, 1, 1, InterpOpNoArgs)
OPDEF(INTOP_BREAKPOINT, "breakpoint", 1, 0, 0, InterpOpNoArgs)
Expand Down
12 changes: 12 additions & 0 deletions src/coreclr/vm/interpexec.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2172,6 +2172,18 @@ void InterpExecMethod(InterpreterFrame *pInterpreterFrame, InterpMethodContextFr
ip += 4;
break;
}
case INTOP_INITBLK:
{
void* dst = LOCAL_VAR(ip[1], void*);
uint8_t value = LOCAL_VAR(ip[2], uint8_t);
uint32_t size = LOCAL_VAR(ip[3], uint32_t);
if (size && !dst)
COMPlusThrow(kNullReferenceException);
else
memset(dst, value, size);
ip += 4;
break;
}
case INTOP_LOCALLOC:
{
size_t len = LOCAL_VAR(ip[2], size_t);
Expand Down
10 changes: 5 additions & 5 deletions src/coreclr/vm/jitinterface.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1920,15 +1920,15 @@ bool CEEInfo::canAllocateOnStack(CORINFO_CLASS_HANDLE clsHnd)
unsigned CEEInfo::getClassAlignmentRequirement(CORINFO_CLASS_HANDLE type, bool fDoubleAlignHint)
{
CONTRACTL {
NOTHROW;
GC_NOTRIGGER;
THROWS;
GC_TRIGGERS;
MODE_PREEMPTIVE;
} CONTRACTL_END;

// Default alignment is sizeof(void*)
unsigned result = TARGET_POINTER_SIZE;

JIT_TO_EE_TRANSITION_LEAF();
JIT_TO_EE_TRANSITION();

TypeHandle clsHnd(type);

Expand All @@ -1950,14 +1950,14 @@ unsigned CEEInfo::getClassAlignmentRequirement(CORINFO_CLASS_HANDLE type, bool f
result = getClassAlignmentRequirementStatic(clsHnd);
}

EE_TO_JIT_TRANSITION_LEAF();
EE_TO_JIT_TRANSITION();

return result;
}

unsigned CEEInfo::getClassAlignmentRequirementStatic(TypeHandle clsHnd)
{
LIMITED_METHOD_CONTRACT;
STANDARD_VM_CONTRACT;

// Default alignment is sizeof(void*)
unsigned result = TARGET_POINTER_SIZE;
Expand Down