[Android][Testing] Fix detection of supported TLS versions on Android #119097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl |
simonrozsival
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the detection of TLS 1.0 and 1.1 support on Android to properly handle the restriction introduced in Android API 35. Starting with Android 15, TLS 1.0 and 1.1 are no longer supported for apps targeting that API level.
Key changes:
- Separates Android TLS version detection from macOS detection logic
- Implements proper API level-based TLS support detection for Android using existing
AndroidGetSslProtocolSupportmethod
liveans
approved these changes
Aug 26, 2025
simonrozsival
deleted the
dev/srozsival/fix-android-platform-detection-supported-tls-versions
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting in Android API 35, TLS 1.0 and 1.1 are not supported:
Our tests assumed that these protocol versions are supported across all Android versions. We need to change the
PlatformDetectionimplementation going forward.Fixes #119016