Skip to content

[Android][Testing] Fix detection of supported TLS versions on Android #119097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2025
Merged

[Android][Testing] Fix detection of supported TLS versions on Android #119097

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,12 +569,18 @@ private static bool AndroidGetSslProtocolSupport(SslProtocols protocol)
#pragma warning disable SYSLIB0039 // TLS versions 1.0 and 1.1 have known vulnerabilities
private static bool GetTls10Support()
{
// on macOS and Android TLS 1.0 is supported.
if ((IsApplePlatform && !IsNetworkFrameworkEnabled()) || IsAndroid)
// on macOS TLS 1.0 is supported.
if (IsApplePlatform && !IsNetworkFrameworkEnabled())
{
return true;
}

// on Android TLS 1.0 support depends on API level
if (IsAndroid)
{
return AndroidGetSslProtocolSupport(SslProtocols.Tls);
}

// Windows depend on registry, enabled by default on all supported versions.
if (IsWindows)
{
Expand All @@ -597,11 +603,16 @@ private static bool GetTls11Support()
// It is enabled on other versions unless explicitly disabled.
return GetProtocolSupportFromWindowsRegistry(SslProtocols.Tls11, defaultProtocolSupport: true) && !IsWindows10Version20348OrGreater;
}
// on macOS and Android TLS 1.1 is supported.
else if ((IsApplePlatform && !IsNetworkFrameworkEnabled()) || IsAndroid)
// on macOS TLS 1.1 is supported.
else if (IsApplePlatform && !IsNetworkFrameworkEnabled())
{
return true;
}
// on Android TLS 1.1 support depends on API level
else if (IsAndroid)
{
return AndroidGetSslProtocolSupport(SslProtocols.Tls11);
}

return IsOpenSslSupported && OpenSslGetTlsSupport(SslProtocols.Tls11);
}
Expand Down