Skip to content

Conversation

maraf
Copy link
Member

@maraf maraf commented Sep 30, 2025

In dotnet/sdk#50949 we changed the identity of StaticWebAsset to contain fingerprint (dotnet.native.wasm -> dotnet.native.FP.wasm). This PR accommodates this when checking for dotnet.native.wasm asset from build.

The SDK change didn't flown to the runtime yet, and so Wasm.Build.Tests won't test it yet.

Contributes to dotnet/sdk#51045

@maraf maraf added this to the 11.0.0 milestone Sep 30, 2025
@maraf maraf self-assigned this Sep 30, 2025
@maraf maraf added arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm labels Sep 30, 2025
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara
See info in area-owners.md if you want to be subscribed.

@pavelsavara

This comment was marked as resolved.

@lewing
Copy link
Member

lewing commented Sep 30, 2025

/backport to release/10.0-rc2

Copy link
Contributor

Started backporting to release/10.0-rc2: https://github.com/dotnet/runtime/actions/runs/18138997412

@pavelsavara
Copy link
Member

Just checking: The PR that caused the regression is talking about blazor.webassembly.js. Do we have the same problem of ignoring blazor.webassembly.<FP>.js ?

@maraf
Copy link
Member Author

maraf commented Sep 30, 2025

Just checking: The PR that caused the regression is talking about blazor.webassembly.js. Do we have the same problem of ignoring blazor.webassembly.<FP>.js ?

No, blazor.js isn't affected by AOT compilation

@maraf
Copy link
Member Author

maraf commented Sep 30, 2025

Verified the change fixes the scenario with latest SDK

@maraf maraf marked this pull request as ready for review September 30, 2025 20:19
@Copilot Copilot AI review requested due to automatic review settings September 30, 2025 20:19
@maraf maraf enabled auto-merge (squash) September 30, 2025 20:20
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the WebAssembly asset identity checking logic to accommodate fingerprinted filenames introduced in the SDK, where dotnet.native.wasm becomes dotnet.native.FP.wasm (where FP is a fingerprint).

  • Changes exact filename matching to pattern matching for dotnet.native.wasm files
  • Maintains backward compatibility with existing non-fingerprinted assets

@maraf maraf merged commit 0fce5eb into dotnet:main Sep 30, 2025
31 of 33 checks passed
@maraf maraf deleted the BrowserFingerprintAssetIdentity branch October 1, 2025 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants