-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[browser] Expect fingerprint in dotnet.native.wasm asset identity #120249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
This comment was marked as resolved.
This comment was marked as resolved.
/backport to release/10.0-rc2 |
Started backporting to release/10.0-rc2: https://github.com/dotnet/runtime/actions/runs/18138997412 |
Just checking: The PR that caused the regression is talking about |
No, blazor.js isn't affected by AOT compilation |
Verified the change fixes the scenario with latest SDK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates the WebAssembly asset identity checking logic to accommodate fingerprinted filenames introduced in the SDK, where dotnet.native.wasm
becomes dotnet.native.FP.wasm
(where FP is a fingerprint).
- Changes exact filename matching to pattern matching for dotnet.native.wasm files
- Maintains backward compatibility with existing non-fingerprinted assets
In dotnet/sdk#50949 we changed the identity of StaticWebAsset to contain fingerprint (
dotnet.native.wasm
->dotnet.native.FP.wasm
). This PR accommodates this when checking fordotnet.native.wasm
asset from build.The SDK change didn't flown to the runtime yet, and so Wasm.Build.Tests won't test it yet.
Contributes to dotnet/sdk#51045