Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 30, 2025

Backport of #120249 to release/10.0-rc2

In dotnet/sdk#50949 we changed the identity of StaticWebAsset to contain fingerprint (dotnet.native.wasm -> dotnet.native.FP.wasm). This PR accommodates this when checking for dotnet.native.wasm asset from build.

The SDK change didn't flown to the runtime yet, and so Wasm.Build.Tests won't test it yet.

Fixes dotnet/sdk#51045

/cc @lewing @maraf

Customer Impact

  • Customer reported
  • Found internally

dotnet/sdk#51045

Regression

  • Yes
  • No

Introduced in dotnet/sdk#50949 which added a fingerprint to the msbuild item identity

Testing

Automated tests.

Risk

Low. The change is covered with automated tests

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

Package authoring no longer needed in .NET 9

IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.

@lewing lewing requested a review from maraf September 30, 2025 18:02
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved for rc2

@lewing lewing added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Sep 30, 2025
@maraf maraf added arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm labels Oct 1, 2025
@maraf maraf added this to the 10.0.0 milestone Oct 1, 2025
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara
See info in area-owners.md if you want to be subscribed.

@lewing lewing merged commit cc5f4c0 into release/10.0-rc2 Oct 1, 2025
40 of 42 checks passed
@lewing lewing deleted the backport/pr-120249-to-release/10.0-rc2 branch October 1, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants