Seal internal and private classes in corelib #49958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
approved these changes
Mar 21, 2021
src/coreclr/System.Private.CoreLib/Tools/GenUnicodeProp/TableLevels.cs
Outdated
Show resolved
Hide resolved
src/coreclr/System.Private.CoreLib/src/System/Diagnostics/StackFrameHelper.cs
Outdated
Show resolved
Hide resolved
GrabYourPitchforks
approved these changes
Mar 21, 2021
stephentoub
force-pushed
the
sealcorelib
branch
from
e459790 to
94433fb
Compare
|
Sealing __Canon broke one ConcurrentBag test that tried to CopyTo an Exception[] into an InvalidOperationException[]... the test expected a cast exception, but in release, it didn't get one. |
Comment on lines
28
to
+31
| // SymWrapperCore is never instantiated and is used as an encapsulation class. | ||
| // It is our "ISymWrapper.dll" assembly within an assembly. | ||
| //------------------------------------------------------------------------------ | ||
| internal class SymWrapperCore | ||
| internal sealed class SymWrapperCore |
There was a problem hiding this comment.
Should SymWrapperCore be made a static class?
There was a problem hiding this comment.
Seems like it probably can be.
There was a problem hiding this comment.
I think there is CA1052 rule for that ;-)
There was a problem hiding this comment.
I postponed turning that on in the past due to the number of changes required, but I'll take another look at it.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #49944