Skip to content

Seal internal and private classes in corelib #49958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 22, 2021
Merged

Seal internal and private classes in corelib #49958

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
646938f
Seal private classes in corelib
stephentoub Mar 21, 2021
94433fb
Seal internal classes in corelib
stephentoub Mar 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,6 @@
<Compile Include="$(BclSourcesRoot)\System\Collections\Generic\Comparer.CoreCLR.cs" />
<Compile Include="$(BclSourcesRoot)\System\Collections\Generic\ComparerHelpers.cs" />
<Compile Include="$(BclSourcesRoot)\System\Collections\Generic\EqualityComparer.CoreCLR.cs" />
<Compile Include="$(BclSourcesRoot)\System\Collections\ObjectModel\ReadOnlyDictionary.cs" />
<Compile Include="$(BclSourcesRoot)\System\Currency.cs" />
<Compile Include="$(BclSourcesRoot)\System\Delegate.CoreCLR.cs" />
<Compile Include="$(BclSourcesRoot)\System\Diagnostics\Debugger.cs" />
Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/System.Private.CoreLib/Tools/GenUnicodeProp/TableLevels.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

namespace GenUnicodeProp
{
internal class TableLevels
internal sealed class TableLevels
{
public readonly int Level1Bits;
public readonly int Level2Bits;
Expand Down
4 changes: 2 additions & 2 deletions src/coreclr/System.Private.CoreLib/src/Internal/Runtime/InteropServices/ComActivator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,7 @@ private static AssemblyLoadContext GetALC(string assemblyPath)
}

[ComVisible(true)]
private class BasicClassFactory : IClassFactory
private sealed class BasicClassFactory : IClassFactory
{
#if FEATURE_COMINTEROP_UNMANAGED_ACTIVATION
private readonly Guid _classId;
Expand Down Expand Up @@ -578,7 +578,7 @@ public void LockServer([MarshalAs(UnmanagedType.Bool)] bool fLock)
}

[ComVisible(true)]
private class LicenseClassFactory : IClassFactory2
private sealed class LicenseClassFactory : IClassFactory2
{
#if FEATURE_COMINTEROP_UNMANAGED_ACTIVATION
private readonly LicenseInteropProxy _licenseProxy = new LicenseInteropProxy();
Expand Down
Loading