Skip to content

Conversation

JamesWTruher
Copy link
Contributor

the native library enum for the posix signal and the managed enum PosixSignal don't match and they probably should.

@ghost
Copy link

ghost commented Sep 3, 2021

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Sep 3, 2021
@stephentoub stephentoub added this to the 6.0.0 milestone Sep 4, 2021
@stephentoub stephentoub requested a review from tmds September 4, 2021 00:28
@tmds
Copy link
Member

tmds commented Sep 4, 2021

Oops... poor copy-pasting. I checked the other values, they are in order.

Thank you for fixing!

@stephentoub
Copy link
Member

Is it possible to write tests that would catch this, even if manual ones?

@stephentoub
Copy link
Member

/backport to release/6.0

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2021

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1200970208

@tmds
Copy link
Member

tmds commented Sep 4, 2021

Is it possible to write tests that would catch this, even if manual ones?

We can add/update a test so it uses the kill executable with a signal name. That way we check our own mapping against that of kill. I'll look into it.

@stephentoub
Copy link
Member

Thanks, Tom.

@ghost ghost locked as resolved and limited conversation to collaborators Oct 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Runtime.InteropServices community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants