PosixSignalRegistrationTests.Unix: validate signal pal mapping #58711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
reviewed
Sep 6, 2021
...me.InteropServices/tests/System/Runtime/InteropServices/PosixSignalRegistrationTests.Unix.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Sep 6, 2021
...me.InteropServices/tests/System/Runtime/InteropServices/PosixSignalRegistrationTests.Unix.cs
Outdated
Show resolved
Hide resolved
|
The CI fails on Debian because |
stephentoub
reviewed
Sep 6, 2021
...me.InteropServices/tests/System/Runtime/InteropServices/PosixSignalRegistrationTests.Unix.cs
Outdated
Show resolved
Hide resolved
|
CI fail is unrelated. This is good to merge. |
stephentoub
reviewed
Sep 7, 2021
| using var process = Process.Start(new ProcessStartInfo | ||
| { | ||
| FileName = "/bin/sh", // Use a shell because not all platforms include a 'kill' executable. | ||
| ArgumentList = { "-c", $"kill -s {sigArg} {Environment.ProcessId.ToString()}" } |
There was a problem hiding this comment.
Nit:
Suggested change
| ArgumentList = { "-c", $"kill -s {sigArg} {Environment.ProcessId.ToString()}" } | |
| ArgumentList = { "-c", $"kill -s {sigArg} {Environment.ProcessId}" } |
stephentoub
approved these changes
Sep 7, 2021
stephentoub
pushed a commit
that referenced
this pull request
Sep 7, 2021
* PosixSignalRegistrationTests.Unix: validate signal pal mapping * Use InvariantCulture for pid ToString * Invoke kill through shell. * Remove InvariantCulture
danmoseley
pushed a commit
that referenced
this pull request
Sep 8, 2021
…managed code. (#58682) * The signal enum in the native library should match the managed code. * PosixSignalRegistrationTests.Unix: validate signal pal mapping (#58711) * PosixSignalRegistrationTests.Unix: validate signal pal mapping * Use InvariantCulture for pid ToString * Invoke kill through shell. * Remove InvariantCulture Co-authored-by: James Truher <[email protected]> Co-authored-by: Tom Deseyn <[email protected]>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catches wrong mappings as in #58658.
cc @stephentoub @JamesWTruher