Check if External Object Context is still active after a possible GC #59285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to release/6.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1247477775 |
Check if `IsActive()` during consideration too.
Use detach state instead of IsActive state for EOC.
elinor-fung
approved these changes
Sep 20, 2021
Co-authored-by: Elinor Fung <[email protected]>
Co-authored-by: Elinor Fung <[email protected]>
This change relies on this AllocateObjectArray call not triggering multiple GCs. While I think that such behavior would be unusual, I don't think its a good practice to rely on such a detail. Refers to: src/coreclr/vm/interoplibinterface_comwrappers.cpp:355 in e820da6. [](commit_id = e820da6, deletion_comment = False) |
davidwrighton
approved these changes
Sep 21, 2021
AaronRobinsonMSFT
added a commit
that referenced
this pull request
Sep 21, 2021
…59285) * Handle a possible GC after allocating an array by iterating over the hash again. Co-authored-by: Elinor Fung <[email protected]>
|
/backport to release/6.0-rc2 |
|
Started backporting to release/6.0-rc2: https://github.com/dotnet/runtime/actions/runs/1259570246 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comments in this code detail the logic and reasons for failure.
This should be considered for .NET 6.
Fixes #59072
/cc @davidwrighton @jkoritzinsky @elinor-fung