Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 18, 2021

Backport of #59285 to release/6.0

/cc @AaronRobinsonMSFT

Customer Impact

This would have impact on WinRT scenarios during Reference Tracker (Jupiter shutdown). This supports an API that had severe implementation flaws and went unused in .NET Framework scenarios. This adds support for its use in .NET 6+.

Testing

The issue was detected via a GCStress run – #59072.

Risk

Low. This is only used in WinRT scenarios – IReferenceTrackerHost::NotifyEndOfReferenceTrackingOnThread().

@ghost ghost added the area-Interop-coreclr label Sep 18, 2021
@AaronRobinsonMSFT AaronRobinsonMSFT marked this pull request as draft September 20, 2021 22:06
…59285)

* Handle a possible GC after allocating an array by iterating over the hash again.

Co-authored-by: Elinor Fung <[email protected]>
@AaronRobinsonMSFT AaronRobinsonMSFT force-pushed the backport/pr-59285-to-release/6.0 branch from 162a3c3 to dedd799 Compare September 21, 2021 22:15
@AaronRobinsonMSFT AaronRobinsonMSFT marked this pull request as ready for review September 21, 2021 22:16
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. We should consider this for .NET 6.

@jeffschwMSFT jeffschwMSFT added the Servicing-consider Issue for next servicing release review label Sep 21, 2021
@jeffschwMSFT jeffschwMSFT added this to the 6.0.0 milestone Sep 21, 2021
@jeffschwMSFT jeffschwMSFT removed the Servicing-consider Issue for next servicing release review label Sep 23, 2021
@jeffschwMSFT
Copy link
Member

Merged into RC2 via #59436

@AaronRobinsonMSFT AaronRobinsonMSFT deleted the backport/pr-59285-to-release/6.0 branch September 27, 2021 18:05
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants