Take into account zero-offset field sequences when propagating locals #64701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsUsing tree VNs runs into the problem described in #64700. We're expecting some small number of diffs from more/fewer propagations. Fixes #64700. Also should fix the
|
SingleAccretion
changed the title
SingleAccretion
force-pushed
the
Prop-Loc-Fix
branch
2 times, most recently
from
724543b to
c5451c1
Compare
|
@dotnet/jit-contrib |
LCL_VAR use VN != VN of its SSA def. Using one for replacement can run afoul of substituting into a LCL_VAR that has a zero-offset field sequence on top and thus duplicate the sequence (as the replacement def will already have this sequence incorporated into its VN).
Just one diff, missing null check elimination: we propagated a field sequence for an array address (PtrToArrElem) that later wasn't recognized as implying non-nullness of another PtrToArrElem to the same array.
SingleAccretion
force-pushed
the
Prop-Loc-Fix
branch
from
c5451c1 to
c63988c
Compare
jakobbotsch
reviewed
Feb 8, 2022
jakobbotsch
approved these changes
Feb 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not doing so runs into the problem described in #64700.
Some small number of diffs from more/fewer propagations.
Fixes #64700.
Fixes #64761.