-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Take into account zero-offset field sequences when propagating locals #64701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
82 changes: 82 additions & 0 deletions
82
src/tests/JIT/Regression/JitBlue/Runtime_64700/Runtime_64700.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| using System; | ||
| using System.Numerics; | ||
| using System.Runtime.CompilerServices; | ||
|
|
||
| class Runtime_64700 | ||
| { | ||
| private static StructWithVtors _structWithVtorsStatic; | ||
|
|
||
| static int Main() | ||
| { | ||
| _structWithVtorsStatic = new StructWithVtors { StructWithOneVtor = { OneVtor = new Vector2(1, 0) } }; | ||
|
|
||
| if (ProblemWithCopyProp(0) != 0) | ||
| { | ||
| return 101; | ||
| } | ||
|
|
||
| if (ProblemWithLocalAssertionProp(new SmallerStruct[] { default }) != 1) | ||
| { | ||
| return 102; | ||
| } | ||
|
|
||
| return 100; | ||
| } | ||
|
|
||
| [MethodImpl(MethodImplOptions.NoInlining)] | ||
| private static float ProblemWithCopyProp(float a) | ||
| { | ||
| ref var p1 = ref _structWithVtorsStatic.StructWithOneVtor.OneVtor; | ||
| ref var p2 = ref _structWithVtorsStatic; | ||
|
|
||
| if (_structWithVtorsStatic.StructWithOneVtor.OneVtor.X == 1) | ||
| { | ||
| p2.StructWithOneVtor.OneVtor = Vector2.Zero; | ||
| if (_structWithVtorsStatic.StructWithOneVtor.OneVtor.X == 1) | ||
| { | ||
| a = 1; | ||
| } | ||
| } | ||
|
|
||
| return a + p1.Y; | ||
| } | ||
|
|
||
| struct StructWithVtors | ||
| { | ||
| public StructWithOneVtor StructWithOneVtor; | ||
| } | ||
|
|
||
| struct StructWithOneVtor | ||
| { | ||
| public Vector2 OneVtor; | ||
| } | ||
|
|
||
| [MethodImpl(MethodImplOptions.NoInlining)] | ||
| private static long ProblemWithLocalAssertionProp(SmallerStruct[] a) | ||
| { | ||
| ref var p1 = ref a[0]; | ||
| Use(ref p1); | ||
| ref var p2 = ref p1.RegStruct; | ||
| Use(ref p2); | ||
|
|
||
| var t = p2.FirstLngValue; | ||
| a[0].RegStruct.FirstLngValue = 1; | ||
|
|
||
| return t + p2.FirstLngValue; | ||
| } | ||
|
|
||
| public static void Use<T>(ref T arg) { } | ||
|
|
||
| struct SmallerStruct | ||
| { | ||
| public RegStruct RegStruct; | ||
| } | ||
|
|
||
| struct RegStruct | ||
| { | ||
| public long FirstLngValue; | ||
| } | ||
| } |
17 changes: 17 additions & 0 deletions
17
src/tests/JIT/Regression/JitBlue/Runtime_64700/Runtime_64700.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
| <PropertyGroup> | ||
| <OutputType>Exe</OutputType> | ||
| <Optimize>True</Optimize> | ||
| <CLRTestBatchPreCommands><![CDATA[ | ||
| $(CLRTestBatchPreCommands) | ||
| set DOTNET_JitOptRepeat=ProblemWithCopyProp | ||
| ]]></CLRTestBatchPreCommands> | ||
| <BashCLRTestPreCommands><![CDATA[ | ||
| $(BashCLRTestPreCommands) | ||
| export DOTNET_JitOptRepeat=ProblemWithCopyProp | ||
| ]]></BashCLRTestPreCommands> | ||
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <Compile Include="$(MSBuildProjectName).cs" /> | ||
| </ItemGroup> | ||
| </Project> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.