Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Feb 9, 2022

Backport of #64833 to release/6.0

/cc @jkotas

Customer Impact

Build break in source build introduced by .NET SDK picking up a newer version of System.Command line library that conflicts with the version used by ILVerify tool. The fix is to disable building of ILVerify tool in source build.

Testing

Fix verified locally: #64817 (comment)

Risk

Low

@ghost
Copy link

ghost commented Feb 9, 2022

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #64833 to release/6.0

/cc @jkotas

Customer Impact

Testing

Risk

Author: github-actions[bot]
Assignees: -
Labels:

area-Infrastructure-coreclr

Milestone: -

@jkotas jkotas requested a review from MichaelSimons February 9, 2022 16:35
@jkotas jkotas added the area-Tools-ILVerification Issues related to ilverify tool and IL verification in general label Feb 9, 2022
@ghost
Copy link

ghost commented Feb 9, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #64833 to release/6.0

/cc @jkotas

Customer Impact

Build break in source build introduced by .NET SDK picking up a newer version of System.Command line library that conflicts with the version used by ILVerify tool. The fix is to disable building of ILVerify tool in source build.

Testing

Fix verified locally: #64817 (comment)

Risk

Low

Author: github-actions[bot]
Assignees: -
Labels:

area-Infrastructure-coreclr, area-ILVerification

Milestone: -

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. We should take for consideration in 6.0.x

@jkotas jkotas requested a review from TIHan February 9, 2022 17:50
@jeffschwMSFT jeffschwMSFT added the Servicing-consider Issue for next servicing release review label Feb 10, 2022
@leecow leecow added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Feb 10, 2022
@leecow leecow added this to the 6.0.3 milestone Feb 10, 2022
@jeffschwMSFT jeffschwMSFT merged commit 4fde4c1 into release/6.0 Feb 10, 2022
@akoeplinger akoeplinger deleted the backport/pr-64833-to-release/6.0 branch February 12, 2022 00:21
@ghost ghost locked as resolved and limited conversation to collaborators Mar 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Tools-ILVerification Issues related to ilverify tool and IL verification in general Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants