Skip to content

dotnet new Razor has weird result #3038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DavidKarlas opened this issue Apr 14, 2021 · 2 comments · Fixed by #3191
Closed

dotnet new Razor has weird result #3038

DavidKarlas opened this issue Apr 14, 2021 · 2 comments · Fixed by #3191
Assignees
Labels
triaged The issue was evaluated by the triage team, placed on correct area, next action defined.
Milestone

Comments

@DavidKarlas
Copy link
Contributor

No description provided.

@bekir-ozturk
Copy link
Contributor

Tags are no longer matched with dotnet new anymore. This issue is fixed in main branch already. Closing.

@vlada-shubina
Copy link
Member

vlada-shubina commented Apr 19, 2021

This happens due to razor is synonym short name to webapp. We only show first name in the list, therefore razor was not visible anywhere.

I will move it to May to fix it:

  • we should show all short names in --list (and other table outputs)
  • for template resolution where we consider all short names in the group, we should show all names in the grou
  • we should test if existing templates are sharing too much names in 2.1 - 6.0, if yes we should consider showing only highest precedence short names
  • when fixing above consider refactoring of the code
  • TemplateGroups should be created as first step of template resolution logic and matching should be done through them, consider implementing ITemplateInfo interface for TemplateGroup so filtering logic can be done in place for template groups and not individual templates.
  • TemplateGroup should carry all the logic of short names in use.
  • eliminate SetupTemplateInfoWithGroupShortNames and related classes - this should be done inside template group.

image

@vlada-shubina vlada-shubina added the triaged The issue was evaluated by the triage team, placed on correct area, next action defined. label Apr 19, 2021
@vlada-shubina vlada-shubina removed their assignment Apr 21, 2021
@vlada-shubina vlada-shubina self-assigned this May 19, 2021
vlada-shubina added a commit to vlada-shubina/templating that referenced this issue May 21, 2021
vlada-shubina added a commit to vlada-shubina/templating that referenced this issue Jun 7, 2021
vlada-shubina added a commit to vlada-shubina/templating that referenced this issue Jun 7, 2021
vlada-shubina added a commit to vlada-shubina/templating that referenced this issue Jun 8, 2021
GangWang01 pushed a commit to GangWang01/sdk that referenced this issue Jun 7, 2022
GangWang01 pushed a commit to GangWang01/sdk that referenced this issue Jun 21, 2022
GangWang01 pushed a commit to GangWang01/sdk that referenced this issue Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triaged The issue was evaluated by the triage team, placed on correct area, next action defined.
Projects
None yet
3 participants