-
Notifications
You must be signed in to change notification settings - Fork 387
fixes dotnet/templating#3038 show all available short names for template group #3191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example of the output for ASP.NET now:
|
209b613
to
05432f5
Compare
05432f5
to
b86b760
Compare
DavidKarlas
approved these changes
May 24, 2021
src/Microsoft.TemplateEngine.Cli/TemplateResolution/TemplateGroup.cs
Outdated
Show resolved
Hide resolved
bekir-ozturk
approved these changes
May 24, 2021
I've opened dotnet/aspnetcore#33067 to remove multiple short names in ASP.NET Core Web App template and get their feedback on how their template is displayed after change. |
50545a8
to
1cc2df2
Compare
1cc2df2
to
00a66a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
need-pm-discussion
Need agreement from PM that the issue aligns to targeted stories for any of the next 2 releases
Priority:0
Work that we can't release without
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
fixes #3038
fixes #2704
Solution
Templates can be matched by:
However, in the table outputs (--list, --search) we only show first short name, and users are not aware about other names (se #3039).
This PR changes it - all short names now will be shown.
Checks:
#nullable enable
to all the modified files ?