Skip to content

fixes dotnet/templating#3038 show all available short names for template group #3191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2021

Conversation

vlada-shubina
Copy link
Member

@vlada-shubina vlada-shubina commented May 21, 2021

Problem

fixes #3038
fixes #2704

Solution

Templates can be matched by:

  • any of short name they have
  • any of short name the group have

However, in the table outputs (--list, --search) we only show first short name, and users are not aware about other names (se #3039).
This PR changes it - all short names now will be shown.

Checks:

  • Added unit tests
  • Added #nullable enable to all the modified files ?

@vlada-shubina vlada-shubina requested a review from a team as a code owner May 21, 2021 10:57
@vlada-shubina vlada-shubina added the need-pm-discussion Need agreement from PM that the issue aligns to targeted stories for any of the next 2 releases label May 21, 2021
@vlada-shubina
Copy link
Member Author

Example of the output for ASP.NET now:

> dotnet new --list 
Template Name                                 Short Name     Language  Tags                  
--------------------------------------------  -------------  --------  ----------------------
Worker Service                                worker         [C#],F#   Common/Worker/Web     
Blazor Server App                             blazorserver   [C#]      Web/Blazor            
Blazor WebAssembly App                        blazorwasm     [C#]      Web/Blazor/WebAssembly
ASP.NET Core Empty                            web            [C#],F#   Web/Empty             
ASP.NET Core Web App (Model-View-Controller)  mvc            [C#],F#   Web/MVC               
ASP.NET Core Web App                          webapp,razor   [C#]      Web/MVC/Razor Pages   
Razor Class Library                           razorclasslib  [C#]      Web/Razor/Library     
ASP.NET Core Web API                          webapi         [C#],F#   Web/WebAPI            
ASP.NET Core gRPC Service                     grpc           [C#]      Web/gRPC              

@vlada-shubina vlada-shubina force-pushed the show-all-short-names branch from 209b613 to 05432f5 Compare May 21, 2021 11:02
@vlada-shubina vlada-shubina changed the title fixes dotnet/templating#3039 show all available short names for template group fixes dotnet/templating#3038 show all available short names for template group May 21, 2021
@vlada-shubina vlada-shubina force-pushed the show-all-short-names branch from 05432f5 to b86b760 Compare May 21, 2021 11:10
@DavidKarlas DavidKarlas removed their assignment May 24, 2021
@vlada-shubina
Copy link
Member Author

I've opened dotnet/aspnetcore#33067 to remove multiple short names in ASP.NET Core Web App template and get their feedback on how their template is displayed after change.

@vlada-shubina vlada-shubina added the do-not-merge The PR should not be merged until impediments are resolved. label May 27, 2021
@vlada-shubina vlada-shubina added Priority:0 Work that we can't release without and removed do-not-merge The PR should not be merged until impediments are resolved. labels Jun 7, 2021
@vlada-shubina vlada-shubina force-pushed the show-all-short-names branch 2 times, most recently from 50545a8 to 1cc2df2 Compare June 7, 2021 19:07
@vlada-shubina vlada-shubina force-pushed the show-all-short-names branch from 1cc2df2 to 00a66a4 Compare June 8, 2021 11:55
@vlada-shubina vlada-shubina merged commit 5d1eea4 into dotnet:main Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-pm-discussion Need agreement from PM that the issue aligns to targeted stories for any of the next 2 releases Priority:0 Work that we can't release without
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dotnet new Razor has weird result Support multiple shortnames in single template
3 participants