Skip to content

Conversation

ThomasGoulet73
Copy link
Contributor

@ThomasGoulet73 ThomasGoulet73 commented Apr 1, 2023

Closes #1

Description

Cleanup following replacing resource constants with properties.

Customer Impact

None.

Regression

No.

Testing

Local build + CI.

Risk

Low.

Microsoft Reviewers: Open in CodeFlow

@ThomasGoulet73 ThomasGoulet73 requested a review from a team as a code owner April 1, 2023 04:32
@ghost ghost assigned ThomasGoulet73 Apr 1, 2023
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Apr 1, 2023
@ghost ghost requested review from dipeshmsft and singhashish-wpf April 1, 2023 04:32
@ghost ghost added the Community Contribution A label for all community Contributions label Apr 1, 2023
@anjaligupta-dev anjaligupta-dev self-requested a review April 4, 2023 12:16
@dipeshmsft
Copy link
Member

@ThomasGoulet73 looks like with this PR we will finally be able to close #1. Thanks for your support on this issue and all the PRs.

@ThomasGoulet73
Copy link
Contributor Author

Thank you @dipeshmsft!

@ThomasGoulet73 ThomasGoulet73 deleted the replace-resource-constants-with-properties-cleanup branch April 28, 2023 14:02
@ghost ghost locked as resolved and limited conversation to collaborators May 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Community Contribution A label for all community Contributions PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use nameof(SRID.PropertyName) syntax instead of depending on GenerateResxSource.GenerateResourcesCodeAsConstants
3 participants