Skip to content

Specify the root package version to Composer so that it won't try to call unavailable command-line programs #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 19, 2025

Conversation

phenaproxima
Copy link
Collaborator

@phenaproxima phenaproxima commented Mar 19, 2025

Trying to get around #39.

To test this, once you download the app, you'll need to take it out of quarantine first because these development snapshots are not signed:

sudo xattr -dr com.apple.quarantine "/path/to/Launch Drupal CMS.app"

@phenaproxima phenaproxima changed the title Use --prefer-install=dist Use --prefer-dist Mar 19, 2025
@phenaproxima phenaproxima changed the title Use --prefer-dist Specify the root package version to Composer so that it wpon try to invoke Git and other command-line utilities Mar 19, 2025
@phenaproxima phenaproxima changed the title Specify the root package version to Composer so that it wpon try to invoke Git and other command-line utilities Specify the root package version to Composer so that it won't try to call unavailable command-line programs Mar 19, 2025
@goba
Copy link
Contributor

goba commented Mar 19, 2025

I've seen the git warning throw up 2 times before. At the very beginning of running the launcher (when it starts installing) and at the very end (immediately the same time when the visit site button appears). This resolved the first one. It did not yet resolve the final one.

@phenaproxima
Copy link
Collaborator Author

Turns out that's core's scaffold plugin trying to be clever: https://github.com/drupal/core-composer-scaffold?tab=readme-ov-file#gitignore

Explicitly setting this to true should disable the attempted Git invocation.

@goba
Copy link
Contributor

goba commented Mar 19, 2025

Still pops up the git warning at the end unfortunately.

@phenaproxima
Copy link
Collaborator Author

@goba confirmed that this is now fixed.

@phenaproxima phenaproxima merged commit efc9969 into main Mar 19, 2025
7 checks passed
@phenaproxima phenaproxima deleted the build/prefer-dist branch March 19, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants