Skip to content

Conversation

trentm
Copy link
Member

@trentm trentm commented Jul 18, 2022

This release is to get the perf improvement from #2786

@trentm trentm requested a review from astorm July 18, 2022 17:06
@trentm trentm self-assigned this Jul 18, 2022
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Jul 18, 2022
@ghost
Copy link

ghost commented Jul 18, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-18T17:06:58.965+0000

  • Duration: 20 min 26 sec

Test stats 🧪

Test Results
Failed 0
Passed 257308
Skipped 0
Total 257308

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run module tests for <modules> : Run TAV tests for one or more modules, where <modules> can be either a comma separated list of modules (e.g. memcached,redis) or the string literal ALL to test all modules

  • run benchmark tests : Run the benchmark test only.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@trentm trentm merged commit c293164 into main Jul 18, 2022
@trentm trentm deleted the trentm/release-3.37.0 branch July 18, 2022 20:42
@trentm
Copy link
Member Author

trentm commented Jul 18, 2022

tagged and 3.x branch updated:

% git tag v3.37.0

% git push origin !$
git push origin v3.37.0
Total 0 (delta 0), reused 0 (delta 0), pack-reused 0
To github.com:elastic/apm-agent-nodejs.git
 * [new tag]           v3.37.0 -> v3.37.0

% git branch -f 3.x main && git push origin 3.x
Total 0 (delta 0), reused 0 (delta 0), pack-reused 0
To github.com:elastic/apm-agent-nodejs.git
   7d3754a1..c2931648  3.x -> 3.x

@trentm
Copy link
Member Author

trentm commented Jul 18, 2022

The jenkins release build failed: https://apm-ci.elastic.co/blue/organizations/jenkins/apm-agent-nodejs%2Fapm-agent-nodejs-mbp/detail/v3.37.0/1/pipeline

[2022-07-18T20:45:49.737Z] + make -C .ci dist
[2022-07-18T20:45:49.737Z] make: Entering directory '/var/lib/jenkins/workspace/ejs_apm-agent-nodejs-mbp_v3.37.0/src/github.com/elastic/apm-agent-nodejs/.ci'
[2022-07-18T20:45:49.737Z] ../dev-utils/make-distribution.sh
[2022-07-18T20:45:50.742Z] elastic-apm-node-3.37.0.tgz
[2022-07-18T20:45:54.760Z] npm WARN deprecated [email protected]: No longer maintained. Use [lru-cache](http://npm.im/lru-cache) version 7.6 or higher, and provide an asynchronous `fetchMethod` option.
[2022-07-18T20:45:56.066Z] 
[2022-07-18T20:45:56.066Z] added 130 packages, and audited 131 packages in 5s
[2022-07-18T20:45:56.066Z] 
[2022-07-18T20:45:56.066Z] 38 packages are looking for funding
[2022-07-18T20:45:56.066Z]   run `npm fund` for details
[2022-07-18T20:45:56.066Z] 
[2022-07-18T20:45:56.066Z] found 0 vulnerabilities
[2022-07-18T20:45:56.970Z] npm ERR! code ELSPROBLEMS
[2022-07-18T20:45:56.970Z] npm ERR! missing: @babel/cli@^7.8.4, required by [email protected]
[2022-07-18T20:45:56.970Z] npm ERR! missing: @babel/core@^7.8.4, required by [email protected]
[2022-07-18T20:45:56.970Z] npm ERR! missing: @babel/preset-env@^7.8.4, required by [email protected]
...

I don't know what that's about, I can build the same step locally:

% make -C .ci dist BRANCH_NAME=v3.37.0
../dev-utils/make-distribution.sh
elastic-apm-node-3.37.0.tgz
npm WARN deprecated [email protected]: No longer maintained. Use [lru-cache](http://npm.im/lru-cache) version 7.6 or higher, and provide an asynchronous `fetchMethod` option.

added 130 packages, and audited 131 packages in 2s

38 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

Created build/dist/elastic-apm-node-lambda-layer.zip

The lambda layer can be published as follows for dev work:
    aws lambda --output json publish-layer-version --layer-name 'trentm-dev-elastic-apm-node' --description 'trentm dev Elastic APM Node.js agent lambda layer' --zip-file 'fileb://build/dist/elastic-apm-node-lambda-layer.zip'
cp ../build/dist/elastic-apm-node-lambda-layer.zip ../build/aws/elastic-apm-node-lambda-layer-v3.37.0.zip

Same error when running a second time in Jenkins: https://apm-ci.elastic.co/blue/organizations/jenkins/apm-agent-nodejs%2Fapm-agent-nodejs-mbp/detail/v3.37.0/2/pipeline/133
Sigh. Something new here.

@trentm
Copy link
Member Author

trentm commented Jul 18, 2022

I am able to repro on an ubuntu:18.04 (which AFAIK is what our linux Jenkins build agents are based on):

Repro
% docker run --rm -ti ubuntu:18.04
root@c06abda830d0:/# apt-get update
...

root@c06abda830d0:/# apt-get install -y git curl make
...

root@c06abda830d0:/# export NVM_DIR="${HOME}/.nvm"
root@c06abda830d0:/#       [ -s "${NVM_DIR}/nvm.sh" ] && . "${NVM_DIR}/nvm.sh"
root@c06abda830d0:/#
root@c06abda830d0:/#       if [ -z "$(command -v nvm)" ]; then
>         rm -fr "${NVM_DIR}"
>         curl -so- https://github.com/raw/nvm-sh/nvm/v0.39.0/install.sh | bash
>       fi
=> Downloading nvm from git to '/root/.nvm'
=> Cloning into '/root/.nvm'...
...

root@c06abda830d0:/# source ~/.nvm/nvm.sh
root@c06abda830d0:/# nvm install v16.15.0
...
Now using node v16.15.0 (npm v8.5.5)

root@c06abda830d0:/# cd root
root@c06abda830d0:~# git clone https://github.com/elastic/apm-agent-nodejs.git
...
root@c06abda830d0:~# cd apm-agent-nodejs/

root@c06abda830d0:~/apm-agent-nodejs# make -C .ci dist BRANCH_NAME=v3.37.0
make: Entering directory '/root/apm-agent-nodejs/.ci'
../dev-utils/make-distribution.sh
elastic-apm-node-3.37.0.tgz
npm WARN deprecated [email protected]: No longer maintained. Use [lru-cache](http://npm.im/lru-cache) version 7.6 or higher, and provide an asynchronous `fetchMethod` option.

added 130 packages, and audited 131 packages in 4s

38 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities
npm notice
npm notice New minor version of npm available! 8.5.5 -> 8.14.0
npm notice Changelog: https://github.com/npm/cli/releases/tag/v8.14.0
npm notice Run npm install -g [email protected] to update!
npm notice
npm ERR! code ELSPROBLEMS
npm ERR! missing: @babel/cli@^7.8.4, required by [email protected]
npm ERR! missing: @babel/core@^7.8.4, required by [email protected]
npm ERR! missing: @babel/preset-env@^7.8.4, required by [email protected]
npm ERR! missing: @elastic/elasticsearch-canary@^8.2.0-canary.2, required by [email protected]
npm ERR! missing: @elastic/elasticsearch@^8.2.0-patch.1, required by [email protected]
npm ERR! missing: @fastify/formbody@^7.0.1, required by [email protected]
npm ERR! missing: @hapi/hapi@^20.1.2, required by [email protected]
npm ERR! missing: @koa/router@^10.1.1, required by [email protected]
npm ERR! missing: @types/node@^18.0.1, required by [email protected]
npm ERR! missing: @types/pino@^6.3.8, required by [email protected]
npm ERR! missing: apollo-server-core@^3.0.0, required by [email protected]
npm ERR! missing: apollo-server-express@^3.0.0, required by [email protected]
npm ERR! missing: aws-sdk@^2.622.0, required by [email protected]
npm ERR! missing: backport@^5.1.2, required by [email protected]
npm ERR! missing: benchmark@^2.1.4, required by [email protected]
npm ERR! missing: bluebird@^3.7.2, required by [email protected]
npm ERR! missing: body-parser@^1.19.0, required by [email protected]
npm ERR! missing: cassandra-driver@^4.4.0, required by [email protected]
npm ERR! missing: clone@^2.0.0, required by [email protected]
npm ERR! missing: columnify@^1.5.4, required by [email protected]
npm ERR! missing: connect@^3.7.0, required by [email protected]
npm ERR! missing: dashdash@^2.0.0, required by [email protected]
npm ERR! missing: dependency-check@^4.1.0, required by [email protected]
npm ERR! missing: elasticsearch@^16.7.3, required by [email protected]
npm ERR! missing: eslint-config-standard@^14.1.1, required by [email protected]
npm ERR! missing: eslint-plugin-import@^2.25.4, required by [email protected]
npm ERR! missing: eslint-plugin-license-header@^0.4.0, required by [email protected]
npm ERR! missing: eslint-plugin-node@^11.1.0, required by [email protected]
npm ERR! missing: eslint-plugin-promise@^4.3.1, required by [email protected]
npm ERR! missing: eslint-plugin-standard@^4.1.0, required by [email protected]
npm ERR! missing: eslint@^6.8.0, required by [email protected]
npm ERR! missing: express-graphql@^0.12.0, required by [email protected]
npm ERR! missing: express-queue@^0.0.13, required by [email protected]
npm ERR! missing: express@^4.17.1, required by [email protected]
npm ERR! missing: fastify@^4.0.2, required by [email protected]
npm ERR! missing: finalhandler@^1.1.2, required by [email protected]
npm ERR! missing: generic-pool@^3.7.1, required by [email protected]
npm ERR! missing: get-port@^5.1.1, required by [email protected]
npm ERR! missing: got@^11.8.5, required by [email protected]
npm ERR! missing: graphql@^15.8.0, required by [email protected]
npm ERR! missing: handlebars@^4.7.3, required by [email protected]
npm ERR! missing: https-pem@^3.0.0, required by [email protected]
npm ERR! missing: ioredis@^5.1.0, required by [email protected]
npm ERR! missing: knex@^0.21.2, required by [email protected]
npm ERR! missing: koa-bodyparser@^4.3.0, required by [email protected]
npm ERR! missing: koa-router@^9.0.1, required by [email protected]
npm ERR! missing: koa@^2.11.0, required by [email protected]
npm ERR! missing: lambda-local@^2.0.2, required by [email protected]
npm ERR! missing: memcached@^2.2.2, required by [email protected]
npm ERR! missing: mimic-response@^2.1.0, required by [email protected]
npm ERR! missing: mkdirp@^0.5.1, required by [email protected]
npm ERR! missing: mongodb-core@^3.2.7, required by [email protected]
npm ERR! missing: mongodb@^4.2.1, required by [email protected]
npm ERR! missing: mysql@^2.18.1, required by [email protected]
npm ERR! missing: mysql2@^2.1.0, required by [email protected]
npm ERR! missing: ndjson@^1.5.0, required by [email protected]
npm ERR! missing: numeral@^2.0.6, required by [email protected]
npm ERR! missing: nyc@^15.0.0, required by [email protected]
npm ERR! missing: pg@^8.7.1, required by [email protected]
npm ERR! missing: pug@^3.0.1, required by [email protected]
npm ERR! missing: redis@^3.1.2, required by [email protected]
npm ERR! missing: request@^2.88.2, required by [email protected]
npm ERR! missing: restify@^8.5.1, required by [email protected]
npm ERR! missing: rimraf@^3.0.2, required by [email protected]
npm ERR! missing: send@^0.17.1, required by [email protected]
npm ERR! missing: tap-junit@^5.0.1, required by [email protected]
npm ERR! missing: tape@^5.0.0, required by [email protected]
npm ERR! missing: tedious@^14.5.0, required by [email protected]
npm ERR! missing: test-all-versions@^4.1.1, required by [email protected]
npm ERR! missing: thunky@^1.1.0, required by [email protected]
npm ERR! missing: typescript@^4.7.4, required by [email protected]
npm ERR! missing: vasync@^2.2.0, required by [email protected]
npm ERR! missing: wait-on@^6.0.1, required by [email protected]
npm ERR! missing: ws@^7.2.1, required by [email protected]

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2022-07-18T22_08_33_984Z-debug-0.log
Makefile:14: recipe for target 'dist' failed
make: *** [dist] Error 1
make: Leaving directory '/root/apm-agent-nodejs/.ci'
root@c06abda830d0:~/apm-agent-nodejs#

@trentm
Copy link
Member Author

trentm commented Jul 19, 2022

The git tag and 3.x branch were moved to the commit for #2831

% git tag -f v3.37.0 93e2d532
Updated tag 'v3.37.0' (was c2931648)

% git push -f origin v3.37.0
Total 0 (delta 0), reused 0 (delta 0), pack-reused 0
To github.com:elastic/apm-agent-nodejs.git
 + c2931648...93e2d532 v3.37.0 -> v3.37.0 (forced update)

% git branch -f 3.x main && git push origin 3.x
Total 0 (delta 0), reused 0 (delta 0), pack-reused 0
To github.com:elastic/apm-agent-nodejs.git
   c2931648..93e2d532  3.x -> 3.x

@trentm
Copy link
Member Author

trentm commented Jul 19, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants