fix: "Dist" step failed in Jenkins with ELSPROBLEMS #2831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "Dist" step in the release process in Jenkinsfile was failing with
npm ERR! code ELSPROBLEMS
npm ERR! missing: @babel/cli@^7.8.4, required by [email protected]
... ditto for every *dev* dependency ...
The part that was actually failing was 'npm ls --omit=dev --all --parseable'
in "gen-notice.sh" when run in a dist try that only has the non-dev deps
installed.
The issue was a too-old npm: node 16.15.0 includes npm 8.5.5, but we
require npm v8.7.0 to get support for 'npm ls --omit=dev ...'
(npm/cli#4744).
github-actions
bot
added
the
agent-nodejs
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
astorm
approved these changes
Jul 19, 2022
Merged
trentm
added a commit
that referenced
this pull request
Aug 2, 2022
Change #2831 showed an example where node v16.15.0 and ealier were insufficient for our dist build. The dist build *for release* is done by CI that specifies the requisite node version, but it could be helpful for a local dev to have a sufficient version. .nvmrc is just advisory, so there is no expected impact.
trentm
added a commit
that referenced
this pull request
Aug 3, 2022
Change #2831 showed an example where node v16.15.0 and ealier were insufficient for our dist build. The dist build *for release* is done by CI that specifies the requisite node version, but it could be helpful for a local dev to have a sufficient version. .nvmrc is just advisory, so there is no expected impact.
PeterEinberger
pushed a commit
to fpm-git/apm-agent-nodejs
that referenced
this pull request
Aug 20, 2024
Change elastic#2831 showed an example where node v16.15.0 and ealier were insufficient for our dist build. The dist build *for release* is done by CI that specifies the requisite node version, but it could be helpful for a local dev to have a sufficient version. .nvmrc is just advisory, so there is no expected impact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Dist" step in the release process in Jenkinsfile was failing with
The part that was actually failing was 'npm ls --omit=dev --all --parseable'
in "gen-notice.sh" when run in a dist try that only has the non-dev deps
installed.
The issue was a too-old npm: node 16.15.0 includes npm 8.5.5, but we
require npm v8.7.0 to get support for 'npm ls --omit=dev ...'
(npm/cli#4744).
Initial discussion for this was on the PR for the 3.37.0 release here: #2830 (comment)
I wasn't able to reproduce this on my dev machine initially because (a) initially I'd been using node v16.15.1 which has a new-enough npm and (b) when I did attempt to repro with v16.15.0 I was foiled because at some point I had upgraded the npm version in my local node v16.15.0 (bad me).