Skip to content

Switch from the Metricbeat metrics naming convention to a dedicated one #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

jlvoiseux
Copy link
Contributor

@jlvoiseux jlvoiseux commented Jun 17, 2022

Motivation / Summary

Following discussions related to the addition of the Lambda metrics to the metrics-internal data stream, I has been proposed to rename the exported Lambda metrics to maintain consistency with similar metrics handled by the APM Server. The switch is as follows:

Existing

aws.lambda.metrics.billed_duration
aws.lambda.metrics.coldstart_duration
aws.lambda.metrics.duration
aws.lambda.metrics.timeout

Proposed

faas.billed_duration
faas.coldstart_duration
faas.duration
faas.timeout

Linked to elastic/apm-server#8400

How to test

Similar to #220, with this branch instead.

Switch from the Metricbeat naming conventions to a dedicated one.
@jlvoiseux jlvoiseux changed the title Switch from the Metricbeat metrics naming convention to a dedicated one. Switch from the Metricbeat metrics naming convention to a dedicated one Jun 17, 2022
@github-actions github-actions bot added the aws-λ-extension AWS Lambda Extension label Jun 17, 2022
@jlvoiseux jlvoiseux marked this pull request as ready for review June 17, 2022 08:57
@jlvoiseux jlvoiseux merged commit 04d2e15 into elastic:main Jun 17, 2022
@apmmachine
Copy link

❕ Build Aborted

Either there was a build timeout or someone aborted the build.

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-17T08:24:01.084+0000

  • Duration: 63 min 59 sec

Test stats 🧪

Test Results
Failed 0
Passed 110
Skipped 2
Total 112

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws-λ-extension AWS Lambda Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants