Skip to content

delete non-documented components missing implementations #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2020

Conversation

mansona
Copy link
Member

@mansona mansona commented Apr 1, 2020

This is removing the remaining components that are not documented in the new styleguide and/or are missing implementations for the new redesign.

Some of these components will likely not be implemented again (because of our new html-first Octane framework 🎉 )

Let me know if you have any questions.

This is blocking #300

@mansona mansona requested review from a team April 1, 2020 15:58
Copy link
Member

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we doing this? All these components had a purpose.

@MelSumner MelSumner changed the title delete non-doumented components missing implementations delete non-documented components missing implementations Apr 1, 2020
@mansona
Copy link
Member Author

mansona commented Apr 1, 2020

@MelSumner this is removing the last few components (some temporarily) that are both not documented and not implemented in the new redesign. It's probably something that we should discuss at a Learning team meeting (or website meeting) but it is currently a prerequisite for getting #300 done

I will happily split this PR into individual PRs removing the components one-by-one if we want to be able to discuss each of them on their merits individually if that helps?

@mansona
Copy link
Member Author

mansona commented Apr 16, 2020

After a lot of conversation about this PR we made a bit of a change to the plan. Some of the components are still being removed either because they don't make sense in the new html-first Octane world or because there are no plans to use them in future. Other components are being moved to a new ember-styleguide-experimental repo that will allow them to continue to be worked on but not block the progress of ember-styleguide 👍

Components that are being deleted

  • es-heading
  • es-main

Components that are being moved

  • es-acordian
  • es-aside
  • es-button-bar
  • es-code-sample
  • es-datatable
  • es-form
  • es-search

@mansona mansona force-pushed the remove-components branch from 5f1b16e to 88038c8 Compare April 16, 2020 12:16
@mansona mansona mentioned this pull request Apr 16, 2020
@mansona mansona force-pushed the remove-components branch from 88038c8 to be4068f Compare April 16, 2020 14:13
@MelSumner MelSumner merged commit 30cc8ea into website-redesign-rfc Apr 17, 2020
@MelSumner MelSumner deleted the remove-components branch April 17, 2020 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants