-
-
Notifications
You must be signed in to change notification settings - Fork 87
Simplify EsHeaderComponent
implementation.
#303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Update the component to use Ember Octane API. - Remove the code for reseting `expanded` on CSS breakpoints for a more predictable behaviour and prevention of memory leaks. - Add `navbar-expanded` class to simplify styles and reduce coupling with HTML structure. - Fix accessibility warnings. - Add additional tests.
highlighted when expanded.
wow thanks for the contribution 🎉 I had a quick glance and it looks mostly ok, although I'm not sure we can use I'm concerned merging this into the I just wanted to let you know that there will be a delay getting this merged but it will likely get merged once that delay is fixed 🎉 |
Thank you for looking at this and sharing the details, @mansona ! It sound great: there is no rush at all with this PR. I'm all for getting the Please, let me know if any help from my side is needed. |
d685368
to
0cd8b45
Compare
@mansona , I've update the PR target to |
@alexeykostevich can you rebase this instead of merging 🤔 the history seems a tiny bit out of whack Let me know if you have any questions about the rebase 👍 I'm happy to help if you need it |
That's a very good point! I've created another PR (#319) with a 1-commit history. |
expanded
on CSS breakpoints fora more predictable behaviour and prevention of memory leaks.
navbar-expanded
class to simplify styles and reduce couplingwith HTML structure.