Should we map libraries specified on the command line to the current variant? -lgl to the required variant
#14341
Comments
This was referenced Jun 2, 2021
sbc100
added a commit
that referenced
this issue
Jun 3, 2021
Normally users don't specify system libraries such as libc or compiler-rt on the command line. However, when they do it makes sense map them to correct variant. For example, linking with `-pthread` + `-lc` will now end up including `libc-mt.a` rather than `libc.a`. Fixes: #14341
sbc100
added a commit
that referenced
this issue
Jun 3, 2021
Normally users don't specify system libraries such as libc or compiler-rt on the command line. However, when they do it makes sense map them to correct variant. For example, linking with `-pthread` + `-lc` will now end up including `libc-mt.a` rather than `libc.a`. Fixes: #14341
sbc100
added a commit
that referenced
this issue
Jun 3, 2021
Normally users don't specify system libraries such as libc or compiler-rt on the command line. However, when they do it makes sense map them to correct variant. For example, linking with `-pthread` + `-lc` will now end up including `libc-mt.a` rather than `libc.a`. Fixes: #14341
sbc100
added a commit
that referenced
this issue
Jun 3, 2021
Normally users don't specify system libraries such as libc or compiler-rt on the command line. However, when they do it makes sense map them to correct variant. For example, linking with `-pthread` + `-lc` will now end up including `libc-mt.a` rather than `libc.a`. Fixes: #14341
sbc100
added a commit
that referenced
this issue
Jun 3, 2021
Normally users don't specify system libraries such as libc or compiler-rt on the command line. However, when they do it makes sense map them to correct variant. For example, linking with `-pthread` + `-lc` will now end up including `libc-mt.a` rather than `libc.a`. Fixes: #14341
sbc100
added a commit
that referenced
this issue
Jun 4, 2021
Normally users don't specify system libraries such as libc or compiler-rt on the command line. However, when they do it makes sense map them to correct variant. For example, linking with `-pthread` + `-lc` will now end up including `libc-mt.a` rather than `libc.a`. Fixes: #14341
sbc100
added a commit
that referenced
this issue
Jun 4, 2021
Normally users don't specify system libraries such as libc or compiler-rt on the command line. However, when they do it makes sense map them to correct variant. For example, linking with `-pthread` + `-lc` will now end up including `libc-mt.a` rather than `libc.a`. Fixes: #14341
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If user specifies
-lcon the command line should we map that to-lc-mtto according to the variant naming scheme intools/system_libraries.py. I tend to think that we should.This will allow things like
-GLto map tolibGL-mt-emu.aautomatically.The text was updated successfully, but these errors were encountered: