Map user-specified system libraries to correct variants #14355
Conversation
|
Added test case. |
sbc100
force-pushed
the
use_library_map
branch
2 times, most recently
from
dfee207 to
b26eb22
Compare
|
Found that I could do this without adding a new pass over the libraries.. much cleaner. |
Normally users don't specify system libraries such as libc or compiler-rt on the command line. However, when they do it makes sense map them to correct variant. For example, linking with `-pthread` + `-lc` will now end up including `libc-mt.a` rather than `libc.a`. Fixes: #14341
|
|
||
| def test_standard_library_mapping(self): | ||
| # Test the `-l` flags on the command line get mapped the correct libraries variant | ||
| self.run_process([EMBUILDER, 'build', 'libc-mt', 'libcompiler_rt-mt', 'libdlmalloc-mt']) |
There was a problem hiding this comment.
Why is the embuilder line needed? (auto library building should happen on line 10639?)
lgtm without line 10636
There was a problem hiding this comment.
Automatic building currently only works for libraries that are added automatically in system_libs.py:calculate().
Libraries specified on the command line are not currently auto-built. This is just how its always been as far as I cant tell. We could change that but its what this change is about.
Also, -nostdlib essentially bypasses system_libs.py:calculate() and doesn't do any auto-adding or auto-building of libraries.
This PR is an incremental improvement. We could integrating -l flags with the auto-building system but that would be bigger/separate change.
Normally users don't specify system libraries such as
libcorcompiler-rton the command line. However, whenthey do, it makes sense map them to correct variant.
For example, linking with
-pthread+-lcwill nowend up including
libc-mt.arather thanlibc.a.Fixes: #14341