Remove @requires_sync_compilation test annotation. NFC #20101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
remove_requires_sync_compilation
branch
from
ac6af27 to
8c8dcc2
Compare
None of these tests require sync compilation anymore as far as I can tell, and even if they did, chrome now supports sync compilation up of wasm files up to 8Mb: chromium/chromium@d1a1a8f Also, rename `test_binaryen_async` to `test_async_compile`. Fixes: #14404
sbc100
force-pushed
the
remove_requires_sync_compilation
branch
from
8c8dcc2 to
f41a41f
Compare
kripken
reviewed
Aug 23, 2023
| @@ -2073,7 +2072,7 @@ def test_cubegeom_pre_regal(self): | |||
| self.btest('third_party/cubegeom/cubegeom_pre.c', reference='third_party/cubegeom/cubegeom_pre.png', args=['-sUSE_REGAL', '-DUSE_REGAL', '-lGL', '-lSDL']) | |||
|
|
|||
| @requires_graphics_hardware | |||
| @requires_sync_compilation | |||
| @no_swiftshader | |||
There was a problem hiding this comment.
If you look at all the other cubegeom_pre.c around this one.. they are all marked as @no_swiftshader. This particular one was never been run under swift shader before due to @requires_sync_compilation .. not that it is running, it fails, due to the swiftshader issue (I assume) so I added the same tag as the surrounding test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None of these tests require sync compilation anymore as far as I can tell, and even if they did, chrome now supports sync compilation up of wasm files up to 8Mb:
chromium/chromium@d1a1a8f
Also, rename
test_binaryen_asynctotest_async_compile.Fixes: #14404