Skip to content

Remove use of @requires_sync_compilation #14404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sbc100 opened this issue Jun 7, 2021 · 0 comments · Fixed by #20101
Closed

Remove use of @requires_sync_compilation #14404

sbc100 opened this issue Jun 7, 2021 · 0 comments · Fixed by #20101

Comments

@sbc100
Copy link
Collaborator

sbc100 commented Jun 7, 2021

Except perhaps for single test, there is no point in running such tests, since they cannot run in chrome.

Unless the test is specifically testing this feature it should not use this decrorator.

I recently broke the build without noticing due to test being skipping on chrome. See #14403.
sbc100 added a commit that referenced this issue Aug 22, 2023
@sbc100
Remove @requires_sync_compilation test annotation. NFC
ac6af27 
None of these tests require sync compilation anymore as far as I can
tell, and even if they did, chrome now supports sync compilation up of
wasm files up to 8Mb:
chromium/chromium@d1a1a8f

Also, rename `test_binaryen_async` to `test_async_compile`.

Fixes: #14404
@sbc100 sbc100 mentioned this issue Aug 22, 2023
Merged
sbc100 added a commit that referenced this issue Aug 23, 2023
@sbc100
Remove @requires_sync_compilation test annotation. NFC
8c8dcc2 
None of these tests require sync compilation anymore as far as I can
tell, and even if they did, chrome now supports sync compilation up of
wasm files up to 8Mb:
chromium/chromium@d1a1a8f

Also, rename `test_binaryen_async` to `test_async_compile`.

Fixes: #14404
sbc100 added a commit that referenced this issue Aug 23, 2023
@sbc100
Remove @requires_sync_compilation test annotation. NFC
f41a41f 
None of these tests require sync compilation anymore as far as I can
tell, and even if they did, chrome now supports sync compilation up of
wasm files up to 8Mb:
chromium/chromium@d1a1a8f

Also, rename `test_binaryen_async` to `test_async_compile`.

Fixes: #14404
sbc100 added a commit that referenced this issue Aug 23, 2023
@sbc100
Remove @requires_sync_compilation test annotation. NFC (#20101)
76652b9 
None of these tests require sync compilation anymore as far as I can
tell, and even if they did, chrome now supports sync compilation up of
wasm files up to 8Mb:
chromium/chromium@d1a1a8f

Also, rename `test_binaryen_async` to `test_async_compile`.

Fixes: #14404
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove @requires_sync_compilation test annotation. NFC emscripten-core/emscripten
1 participant
@sbc100